Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: chrome/renderer/autofill/fake_content_password_manager_driver.h

Issue 2680163006: Eliminate PasswordAutofillAgentConstructed() in mojo interface PasswordManagerDriver (Closed)
Patch Set: Address comments from vabr@ Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/autofill/fake_content_password_manager_driver.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_AUTOFILL_FAKE_CONTENT_PASSWORD_MANAGER_DRIVER_H_ 5 #ifndef CHROME_RENDERER_AUTOFILL_FAKE_CONTENT_PASSWORD_MANAGER_DRIVER_H_
6 #define CHROME_RENDERER_AUTOFILL_FAKE_CONTENT_PASSWORD_MANAGER_DRIVER_H_ 6 #define CHROME_RENDERER_AUTOFILL_FAKE_CONTENT_PASSWORD_MANAGER_DRIVER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 void reset_password_forms_rendered() { 76 void reset_password_forms_rendered() {
77 called_password_forms_rendered_ = false; 77 called_password_forms_rendered_ = false;
78 password_forms_rendered_ = base::nullopt; 78 password_forms_rendered_ = base::nullopt;
79 } 79 }
80 80
81 bool called_record_save_progress() const { 81 bool called_record_save_progress() const {
82 return called_record_save_progress_; 82 return called_record_save_progress_;
83 } 83 }
84 84
85 bool called_agent_constructed() const { return called_agent_constructed_; }
86
87 bool called_save_generation_field() const { 85 bool called_save_generation_field() const {
88 return called_save_generation_field_; 86 return called_save_generation_field_;
89 } 87 }
90 88
91 const base::Optional<base::string16>& save_generation_field() const { 89 const base::Optional<base::string16>& save_generation_field() const {
92 return save_generation_field_; 90 return save_generation_field_;
93 } 91 }
94 92
95 void reset_save_generation_field() { 93 void reset_save_generation_field() {
96 called_save_generation_field_ = false; 94 called_save_generation_field_ = false;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 133
136 void ShowPasswordSuggestions(int key, 134 void ShowPasswordSuggestions(int key,
137 base::i18n::TextDirection text_direction, 135 base::i18n::TextDirection text_direction,
138 const base::string16& typed_username, 136 const base::string16& typed_username,
139 int options, 137 int options,
140 const gfx::RectF& bounds) override; 138 const gfx::RectF& bounds) override;
141 139
142 void ShowNotSecureWarning(base::i18n::TextDirection text_direction, 140 void ShowNotSecureWarning(base::i18n::TextDirection text_direction,
143 const gfx::RectF& bounds) override; 141 const gfx::RectF& bounds) override;
144 142
145 void PasswordAutofillAgentConstructed() override;
146
147 void RecordSavePasswordProgress(const std::string& log) override; 143 void RecordSavePasswordProgress(const std::string& log) override;
148 144
149 void SaveGenerationFieldDetectedByClassifier( 145 void SaveGenerationFieldDetectedByClassifier(
150 const autofill::PasswordForm& password_form, 146 const autofill::PasswordForm& password_form,
151 const base::string16& generation_field) override; 147 const base::string16& generation_field) override;
152 148
153 // Records whether ShowPasswordSuggestions() gets called. 149 // Records whether ShowPasswordSuggestions() gets called.
154 bool called_show_pw_suggestions_ = false; 150 bool called_show_pw_suggestions_ = false;
155 // Records data received via ShowPasswordSuggestions() call. 151 // Records data received via ShowPasswordSuggestions() call.
156 int show_pw_suggestions_key_ = -1; 152 int show_pw_suggestions_key_ = -1;
157 base::Optional<base::string16> show_pw_suggestions_username_; 153 base::Optional<base::string16> show_pw_suggestions_username_;
158 int show_pw_suggestions_options_ = -1; 154 int show_pw_suggestions_options_ = -1;
159 // Records whether ShowNotSecureWarning() gets called. 155 // Records whether ShowNotSecureWarning() gets called.
160 bool called_show_not_secure_warning_ = false; 156 bool called_show_not_secure_warning_ = false;
161 // Records whether PasswordFormSubmitted() gets called. 157 // Records whether PasswordFormSubmitted() gets called.
162 bool called_password_form_submitted_ = false; 158 bool called_password_form_submitted_ = false;
163 // Records data received via PasswordFormSubmitted() call. 159 // Records data received via PasswordFormSubmitted() call.
164 base::Optional<autofill::PasswordForm> password_form_submitted_; 160 base::Optional<autofill::PasswordForm> password_form_submitted_;
165 // Records whether InPageNavigation() gets called. 161 // Records whether InPageNavigation() gets called.
166 bool called_inpage_navigation_ = false; 162 bool called_inpage_navigation_ = false;
167 // Records data received via InPageNavigation() call. 163 // Records data received via InPageNavigation() call.
168 base::Optional<autofill::PasswordForm> password_form_inpage_navigation_; 164 base::Optional<autofill::PasswordForm> password_form_inpage_navigation_;
169 // Records whether PasswordFormsRendered() gets called. 165 // Records whether PasswordFormsRendered() gets called.
170 bool called_password_forms_rendered_ = false; 166 bool called_password_forms_rendered_ = false;
171 // Records data received via PasswordFormsRendered() call. 167 // Records data received via PasswordFormsRendered() call.
172 base::Optional<std::vector<autofill::PasswordForm>> password_forms_rendered_; 168 base::Optional<std::vector<autofill::PasswordForm>> password_forms_rendered_;
173 // Records whether RecordSavePasswordProgress() gets called. 169 // Records whether RecordSavePasswordProgress() gets called.
174 bool called_record_save_progress_ = false; 170 bool called_record_save_progress_ = false;
175 // Records whether PasswordAutofillAgentConstructed() gets called.
176 bool called_agent_constructed_ = false;
177 // Records whether SaveGenerationFieldDetectedByClassifier() gets called. 171 // Records whether SaveGenerationFieldDetectedByClassifier() gets called.
178 bool called_save_generation_field_ = false; 172 bool called_save_generation_field_ = false;
179 // Records data received via SaveGenerationFieldDetectedByClassifier() call. 173 // Records data received via SaveGenerationFieldDetectedByClassifier() call.
180 base::Optional<base::string16> save_generation_field_; 174 base::Optional<base::string16> save_generation_field_;
181 // Records whether PasswordNoLongerGenerated() gets called. 175 // Records whether PasswordNoLongerGenerated() gets called.
182 bool called_password_no_longer_generated_ = false; 176 bool called_password_no_longer_generated_ = false;
183 // Records whether PresaveGeneratedPassword() gets called. 177 // Records whether PresaveGeneratedPassword() gets called.
184 bool called_presave_generated_password_ = false; 178 bool called_presave_generated_password_ = false;
185 179
186 mojo::BindingSet<autofill::mojom::PasswordManagerDriver> bindings_; 180 mojo::BindingSet<autofill::mojom::PasswordManagerDriver> bindings_;
187 }; 181 };
188 182
189 #endif // CHROME_RENDERER_AUTOFILL_FAKE_CONTENT_PASSWORD_MANAGER_DRIVER_H_ 183 #endif // CHROME_RENDERER_AUTOFILL_FAKE_CONTENT_PASSWORD_MANAGER_DRIVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/autofill/fake_content_password_manager_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698