Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: components/safe_browsing_db/v4_local_database_manager.cc

Issue 2680163002: S: GetThreatSeverity should handle the case of CheckResourceUrl. (Closed)
Patch Set: nparker@'s review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_local_database_manager.cc
diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc
index 24013cc83d7a99446047b450ff670f12918cc803..9473604324915093f307a61c12d29e073a199957 100644
--- a/components/safe_browsing_db/v4_local_database_manager.cc
+++ b/components/safe_browsing_db/v4_local_database_manager.cc
@@ -89,8 +89,15 @@ ThreatSeverity GetThreatSeverity(const ListIdentifier& list_id) {
case UNWANTED_SOFTWARE:
return 1;
case API_ABUSE:
+ case CLIENT_INCIDENT:
return 2;
- default:
+
+ case THREAT_TYPE_UNSPECIFIED:
+ case POTENTIALLY_HARMFUL_APPLICATION:
+ case SOCIAL_ENGINEERING:
+ case CSD_WHITELIST:
+ case CSD_DOWNLOAD_WHITELIST:
+ case SUBRESOURCE_FILTER:
NOTREACHED() << "Unexpected ThreatType encountered: "
<< list_id.threat_type();
return kLeastSeverity;

Powered by Google App Engine
This is Rietveld 408576698