S: GetThreatSeverity should handle the case of CheckResourceUrl.

components/safe_browsing_db/v4_local_database_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file should not be build on Android but is currently getting built.
 // TODO(vakh): Fix that: http://crbug.com/621647
 
 #include "components/safe_browsing_db/v4_local_database_manager.h"
 
 #include <vector>
@@ skipping 71 matching lines @@
 // value is 0, which represents the most severe list.
 ThreatSeverity GetThreatSeverity(const ListIdentifier& list_id) {
   switch (list_id.threat_type()) {
     case MALWARE_THREAT:
     case SOCIAL_ENGINEERING_PUBLIC:
     case MALICIOUS_BINARY:
       return 0;
     case UNWANTED_SOFTWARE:
       return 1;
     case API_ABUSE:
+    case CLIENT_INCIDENT:
       return 2;
     default:

[Nathan Parker, 2017/02/07 22:59:58]

How about replacing the default with all the other threat types, so the compiler
will catch it next time we add one?

[vakh (use Gerrit instead), 2017/02/07 23:11:21]

Done.

       NOTREACHED() << "Unexpected ThreatType encountered: "
                    << list_id.threat_type();
       return kLeastSeverity;
   }
 }
 
 }  // namespace
 
 V4LocalDatabaseManager::PendingCheck::PendingCheck(
     Client* client,
@@ skipping 634 matching lines @@
                             db_updated_callback_);
 }
 
 bool V4LocalDatabaseManager::AreStoresAvailableNow(
     const StoresToCheck& stores_to_check) const {
   return enabled_ && v4_database_ &&
          v4_database_->AreStoresAvailable(stores_to_check);
 }
 
 }  // namespace safe_browsing