Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: src/interface-descriptors.h

Issue 2680153005: [builtins] Array.prototype.filter implemented as a TurboFan code stub. (Closed)
Patch Set: turn off flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interface-descriptors.h
diff --git a/src/interface-descriptors.h b/src/interface-descriptors.h
index 95ebb4976ca33c0b2798c5590d992a61b09e8b43..88b41f40c5401e1e098cdf411e3bb3e140a37d57 100644
--- a/src/interface-descriptors.h
+++ b/src/interface-descriptors.h
@@ -57,6 +57,7 @@ class PlatformInterfaceDescriptor;
V(TransitionElementsKind) \
V(AllocateHeapNumber) \
V(Builtin) \
+ V(ArrayFilter) \
V(ArrayConstructor) \
V(IteratingArrayBuiltin) \
V(IteratingArrayBuiltinLoopContinuation) \
@@ -724,6 +725,14 @@ class IteratingArrayBuiltinLoopContinuationDescriptor
DECLARE_BUILTIN_DESCRIPTOR(IteratingArrayBuiltinLoopContinuationDescriptor)
};
+// TODO(mvstanton): It's the same as ForEach and some other array descriptors.
+// Sharing is probably better.
+class ArrayFilterDescriptor : public BuiltinDescriptor {
danno 2017/03/20 16:58:38 I don't think you need this at all anymore....
mvstanton 2017/03/20 22:08:31 Done.
+ public:
+ DEFINE_BUILTIN_PARAMETERS(kCallback, kThisArg)
+ DECLARE_BUILTIN_DESCRIPTOR(ArrayFilterDescriptor)
+};
+
class ArrayConstructorDescriptor : public CallInterfaceDescriptor {
public:
DEFINE_PARAMETERS(kTarget, kNewTarget, kActualArgumentsCount, kAllocationSite)

Powered by Google App Engine
This is Rietveld 408576698