Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

Issue 2680143002: Use dropdown list for admin areas in pr form. (Closed)
Patch Set: Another one with addressing Math's comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
index 7506c43dcbfb1aa56d14bb76847f4072d242de61..3c9164b5c934e56954b04ee05f45ea0c91f72a9f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
@@ -328,7 +328,7 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener
if (nextFieldModel.isFullLine()) useFullLine = true;
}
- if (useFullLine) {
+ if (useFullLine || isLastField) {
addFieldViewToEditor(mDataView, fieldModel);
} else {
// Create a LinearLayout to put it and the next view side by side.
@@ -385,8 +385,8 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener
if (mObserverForTest != null) mObserverForTest.onPaymentRequestReadyToEdit();
}
};
- EditorDropdownField dropdownView =
- new EditorDropdownField(mContext, parent, fieldModel, prepareEditorRunnable);
+ EditorDropdownField dropdownView = new EditorDropdownField(
+ mContext, parent, fieldModel, prepareEditorRunnable, mObserverForTest);
mFieldViews.add(dropdownView);
mDropdownFields.add(dropdownView.getDropdown());

Powered by Google App Engine
This is Rietveld 408576698