Use dropdown list for admin areas in pr form.

chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.autofill;
 
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.test.util.CallbackHelper;
 import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
 import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard;
 import org.chromium.chrome.browser.autofill.PersonalDataManager.PersonalDataManagerObserver;
 
 import java.util.List;
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeoutException;
 
 /**
  * Helper class for testing AutofillProfiles.
  */
 public class AutofillTestHelper {
 
     private final CallbackHelper mOnPersonalDataChangedHelper = new CallbackHelper();
 
     public AutofillTestHelper() {
         registerDataObserver();
         setNormalizationTimeoutForTesting();

[Mathieu, 2017/03/24 17:24:32]

can we have a special value of normalization timeout which is essentially ==
isTestingMode?

[Parastoo, 2017/03/24 22:42:23]

Like checking what the timeout is set to, and based on that decide if it's on
the testing mode? Like this:

if (PDM.getInstance().getRequestTimeout() == 1) {
  // Do this
}

I consider this as a bad design.

Or in setNormalizationTimeoutForTesting(int t) {
   if (t == 1) then setToTestingMode()
}


How about in setToTestingMode, setting the timeout to 1? And then removing the
setNormalizationTimeoutForTesting()?

[Mathieu, 2017/03/27 19:09:06]

I find it weird to have two calls related to testing. I don't think we use the
pattern "testing mode" in many places in the code. Ideally you would
setNormalizationTimeoutForTesting(0) which would tell the code to not even make
the request and return fake/no data right away. Ideally there would be no
concept of "testing mode"

[Mathieu, 2017/03/28 14:43:32]

Still need to address this. 

[Parastoo, 2017/03/29 19:33:55]

Done.

[Parastoo, 2017/03/29 19:33:55]

Done.

+        setToTestingMode();
     }
 
     void setNormalizationTimeoutForTesting() {
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 PersonalDataManager.getInstance().setNormalizationTimeoutForTesting(1);
             }
         });
     }
 
+    void setToTestingMode() {
+        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+            @Override
+            public void run() {
+                PersonalDataManager.getInstance().setToTestingMode();
+            }
+        });
+    }
+
     AutofillProfile getProfile(final String guid) throws ExecutionException {
         return ThreadUtils.runOnUiThreadBlocking(new Callable<AutofillProfile>() {
             @Override
             public AutofillProfile call() {
                 return PersonalDataManager.getInstance().getProfile(guid);
             }
         });
     }
 
     List<AutofillProfile> getProfilesToSuggest(final boolean includeNameInLabel) throws
@@ skipping 301 matching lines @@
                             });
                 }
             });
             if (isDataLoaded) return;
             mOnPersonalDataChangedHelper.waitForCallback(callCount);
         } catch (TimeoutException | InterruptedException | ExecutionException e) {
             throw new AssertionError(e);
         }
     }
 }