VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack bounds.

VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan GC inside Blink. The only differences is that we don't fallback to __libc_stack_end for the main thread.

We also cleanup GetAndValidateIsolateStackBounds a bit to avoid duplication there.

(This change is motivated by https://github.com/dart-lang/sdk/issues/28692 where crash in bootstrapping does not produce any useful stack trace)

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ef40e6091988f0f5e21de9363df2fd823fc698f

[Vyacheslav Egorov (Google), 2017-02-09 15:37:11]

Description was changed from

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

BUG=
==========

to

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread. 

BUG=
==========

[Vyacheslav Egorov (Google), 2017-02-09 15:37:11]

vegorov@google.com changed reviewers:
+ rmacnak@google.com

[Vyacheslav Egorov (Google), 2017-02-09 15:37:24]

Hi Ryan,

Please take a look.

[Vyacheslav Egorov (Google), 2017-02-09 15:38:26]

Description was changed from

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread. 

BUG=
==========

to

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread. 

(This change is motivated by https://github.com/dart-lang/sdk/issues/28692 where
crash in bootstrapping does not produce any useful stack trace)

BUG=
==========

[Vyacheslav Egorov (Google), 2017-02-09 15:39:16]

Description was changed from

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread. 

(This change is motivated by https://github.com/dart-lang/sdk/issues/28692 where
crash in bootstrapping does not produce any useful stack trace)

BUG=
==========

to

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread. 

We also cleanup GetAndValidateIsolateStackBounds a bit to avoid duplication
there.

(This change is motivated by https://github.com/dart-lang/sdk/issues/28692 where
crash in bootstrapping does not produce any useful stack trace)

BUG=
==========

[Cutch, 2017-02-09 16:45:23]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-02-09 16:45:24]

LGTM w/c

https://codereview.chromium.org/2680123004/diff/40001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2680123004/diff/40001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:804: static bool GetAndValidateIsolateStackBounds(
While you're here, this could be renamed to GetAndValidateThreadStackBounds

https://codereview.chromium.org/2680123004/diff/40001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:989: /*get_os_thread_bounds=*/true)) {
I wonder why this isn't the default now?

[Vyacheslav Egorov (Google), 2017-02-09 17:19:20]

Thanks for the review!

https://codereview.chromium.org/2680123004/diff/40001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2680123004/diff/40001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:804: static bool GetAndValidateIsolateStackBounds(
On 2017/02/09 16:45:24, Cutch wrote:
> While you're here, this could be renamed to GetAndValidateThreadStackBounds

Done.

https://codereview.chromium.org/2680123004/diff/40001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:989: /*get_os_thread_bounds=*/true)) {
On 2017/02/09 16:45:24, Cutch wrote:
> I wonder why this isn't the default now?

Because it only works if thread == Thread::Current(), however this function is
called from places where this does not necessarily hold (e.g. on Windows thread
sampling is done from another thread).

[Vyacheslav Egorov (Google), 2017-02-09 18:46:13]

Description was changed from

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread. 

We also cleanup GetAndValidateIsolateStackBounds a bit to avoid duplication
there.

(This change is motivated by https://github.com/dart-lang/sdk/issues/28692 where
crash in bootstrapping does not produce any useful stack trace)

BUG=
==========

to

==========
VM: Teach GetAndValidateIsolateStackBounds(...) to fallback to OS thread stack
bounds.

Currently it relies on OSThread::stack_base_ which is explicitly set.

However if we encounter a crash or assertion failure early we don't have
stack_base_ set yet.

This CL allows us to get correct stack dump even if OSThread::stack_base_ is not
set yet by falling back to low-level APIs:

* On Linux and Android we fallback to pthread_attr_getstack
* On Mac OS X we use pthread_get_stackaddr_np/pthread_get_stacksize_np.
* On Windows we read limits from TIB.

This code is mostly a port of the battle tested thread limits code from Oilpan
GC inside Blink. The only differences is that we don't fallback to
__libc_stack_end for the main thread.

We also cleanup GetAndValidateIsolateStackBounds a bit to avoid duplication
there.

(This change is motivated by https://github.com/dart-lang/sdk/issues/28692 where
crash in bootstrapping does not produce any useful stack trace)

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5ef40e6091988f0f5e21de9363df2fd823fc698f
==========

[Vyacheslav Egorov (Google), 2017-02-09 18:46:14]

Committed patchset #3 (id:40001) manually as
5ef40e6091988f0f5e21de9363df2fd823fc698f (presubmit successful).

[rmacnak, 2017-02-09 19:17:49]

Nice!