Initial Implementation of Iframe Attribute for Feature Policy (Part 1)

third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp

Index: third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..d1d02262c121cca0afbc97cac3561f4ab07f3494
--- /dev/null
+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
@@ -0,0 +1,64 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/html/HTMLIFrameElementAllow.h"
+
+#include "core/dom/Document.h"
+#include "core/html/HTMLIFrameElement.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::UnorderedElementsAre;
+
+namespace blink {
+
+TEST(HTMLIFrameElementAllowTest, ParseAllowedFeatureNamesValid) {

[Rick Byers, 2017/02/09 20:59:59]

We're going to (eventually) need a web-platform-test for this (and the stuff
covered by the other unit test).  It's kind of nice having a unit test, but if
it can be tested nearly as well from a testharness.js test then I'd suggest
doing that instead (with a plan to upstream the tests once there is an official
spec).

[lunalu1, 2017/02/09 23:19:04]

Yes, I was planning to do the layout tests (I mean web-platform-test :P) once
the entire feature policy iframe attribute is implemented. 
This test is only testing the sanity of adding DOMTokenList attribute allow and
how it is correctly parses into a set of enums. 
I guess once part 5 is done. I can remove those tests and add web-platform-tests
instead? 

[Rick Byers, 2017/02/10 22:09:20]

Ok SGTM.  Maybe just add a "// TODO(lunalu) Move to web-platform-tests. 
crbug.com/XXX"?

+  Document* document = Document::create();
+  HTMLIFrameElement* iframe = HTMLIFrameElement::create(*document);
+  HTMLIFrameElementAllow* allow = HTMLIFrameElementAllow::create(iframe);
+  String errorMessage;
+  HashSet<WebFeaturePolicyFeature> result;
+
+  allow->setValue("");
+  result = allow->parseAllowedFeatureNames(errorMessage);
+  EXPECT_TRUE(result.isEmpty());
+
+  allow->setValue("fullscreen");
+  result = allow->parseAllowedFeatureNames(errorMessage);
+  EXPECT_THAT(result,
+              UnorderedElementsAre(WebFeaturePolicyFeature::Fullscreen));
+
+  allow->setValue("fullscreen payment vibrate");
+  result = allow->parseAllowedFeatureNames(errorMessage);
+  EXPECT_THAT(result, UnorderedElementsAre(WebFeaturePolicyFeature::Fullscreen,
+                                           WebFeaturePolicyFeature::Payment,
+                                           WebFeaturePolicyFeature::Vibrate));
+}
+
+TEST(HTMLIFrameElementAllowTest, ParseAllowedFeatureNamesInvalid) {
+  Document* document = Document::create();
+  HTMLIFrameElement* iframe = HTMLIFrameElement::create(*document);
+  HTMLIFrameElementAllow* allow = HTMLIFrameElementAllow::create(iframe);
+  String errorMessage;
+  HashSet<WebFeaturePolicyFeature> result;
+
+  allow->setValue("invalid");
+  result = allow->parseAllowedFeatureNames(errorMessage);
+  EXPECT_TRUE(result.isEmpty());
+  EXPECT_EQ("'invalid' is an invalid feature name.", errorMessage);
+
+  allow->setValue("fullscreen invalid1 invalid2");
+  result = allow->parseAllowedFeatureNames(errorMessage);
+  EXPECT_THAT(result,
+              UnorderedElementsAre(WebFeaturePolicyFeature::Fullscreen));
+  EXPECT_EQ("'invalid1', 'invalid2' are invalid feature names.", errorMessage);
+
+  allow->setValue("fullscreen invalid vibrate fullscreen");
+  result = allow->parseAllowedFeatureNames(errorMessage);
+  EXPECT_EQ("'invalid' is an invalid feature name.", errorMessage);
+  EXPECT_THAT(result, UnorderedElementsAre(WebFeaturePolicyFeature::Fullscreen,
+                                           WebFeaturePolicyFeature::Vibrate));
+}
+
+}  // namespace blink