Initial Implementation of Iframe Attribute for Feature Policy (Part 1)

third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann (hausmann@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Ericsson AB. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 22 matching lines @@
 #include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 inline HTMLIFrameElement::HTMLIFrameElement(Document& document)
     : HTMLFrameElementBase(iframeTag, document),
       m_didLoadNonEmptyDocument(false),
       m_sandbox(HTMLIFrameElementSandbox::create(this)),
+      m_allow(HTMLIFrameElementAllow::create(this)),
       m_referrerPolicy(ReferrerPolicyDefault) {}
 
 DEFINE_NODE_FACTORY(HTMLIFrameElement)
 
 DEFINE_TRACE(HTMLIFrameElement) {
   visitor->trace(m_sandbox);
   visitor->trace(m_permissions);
+  visitor->trace(m_allow);
   HTMLFrameElementBase::trace(visitor);
   Supplementable<HTMLIFrameElement>::trace(visitor);
 }
 
 HTMLIFrameElement::~HTMLIFrameElement() {}
 
 DOMTokenList* HTMLIFrameElement::sandbox() const {
   return m_sandbox.get();
 }
 
 DOMTokenList* HTMLIFrameElement::permissions() const {
   if (!const_cast<HTMLIFrameElement*>(this)->initializePermissionsAttribute())
     return nullptr;
   return m_permissions.get();
 }
 
+DOMTokenList* HTMLIFrameElement::allow() const {
+  return m_allow.get();
+}
+
 bool HTMLIFrameElement::isPresentationAttribute(
     const QualifiedName& name) const {
   if (name == widthAttr || name == heightAttr || name == alignAttr ||
       name == frameborderAttr)
     return true;
   return HTMLFrameElementBase::isPresentationAttribute(name);
 }
 
 void HTMLIFrameElement::collectStyleForPresentationAttribute(
     const QualifiedName& name,
@@ skipping 66 matching lines @@
       m_csp = nullAtom;
       document().addConsoleMessage(ConsoleMessage::create(
           OtherMessageSource, ErrorMessageLevel,
           "'csp' attribute contains non-ASCII characters: " + value));
       return;
     }
     AtomicString oldCSP = m_csp;
     m_csp = value;
     if (m_csp != oldCSP)
       frameOwnerPropertiesChanged();
+  } else if (RuntimeEnabledFeatures::featurePolicyEnabled() &&
+             name == allowAttr) {
+    m_allow->setValue(value);
   } else {
     if (name == srcAttr)
       logUpdateAttributeIfIsolatedWorldAndInDocument("iframe", params);
     HTMLFrameElementBase::parseAttribute(params);
   }
 }
 
 bool HTMLIFrameElement::layoutObjectIsNeeded(const ComputedStyle& style) {
   return contentFrame() && HTMLElement::layoutObjectIsNeeded(style);
 }
@@ skipping 42 matching lines @@
   setSandboxFlags(m_sandbox->value().isNull()
                       ? SandboxNone
                       : parseSandboxPolicy(m_sandbox->tokens(), invalidTokens));
   if (!invalidTokens.isNull())
     document().addConsoleMessage(ConsoleMessage::create(
         OtherMessageSource, ErrorMessageLevel,
         "Error while parsing the 'sandbox' attribute: " + invalidTokens));
   setSynchronizedLazyAttribute(sandboxAttr, m_sandbox->value());
 }
 
+void HTMLIFrameElement::allowValueWasSet() {
+  String invalidTokens;
+  m_allowedFeatureNames = m_allow->parseAllowedFeatureNames(invalidTokens);
+  if (!invalidTokens.isNull()) {
+    document().addConsoleMessage(ConsoleMessage::create(
+        OtherMessageSource, ErrorMessageLevel,
+        "Error while parsing the 'allow' attribute: " + invalidTokens));
+  }
+  setSynchronizedLazyAttribute(allowAttr, m_allow->value());
+  // TODO(lunalu): Once allowedFeatureNames is passed to frame owner, call
+  // frameOwnerPropertiesChanged.
+  // frameOwnerPropertiesChanged();

[iclelland, 2017/02/08 20:11:35]

You can just remove this commented-out code, with the TODO in place.

[lunalu1, 2017/02/08 21:06:11]

Done.

+}
+
 ReferrerPolicy HTMLIFrameElement::referrerPolicyAttribute() {
   return m_referrerPolicy;
 }
 
 bool HTMLIFrameElement::initializePermissionsAttribute() {
   if (!RuntimeEnabledFeatures::permissionDelegationEnabled())
     return false;
 
   if (!m_permissions)
     m_permissions = HTMLIFrameElementPermissions::create(this);
   return true;
 }
 
 }  // namespace blink