Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26800005: chromeos: Remove ScreensaverController. (Closed)

Created:
7 years, 2 months ago by Daniel Erat
Modified:
7 years, 2 months ago
Reviewers:
rkc, stevenjb, Yoyo Zhou
CC:
chromium-reviews, derat+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove ScreensaverController. Remove the ScreensaverController class, which isn't being used anymore. Also remove idle-notification code from PowerManagerClient. BUG=none TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228911

Patch Set 1 #

Patch Set 2 : yay rietveld #

Patch Set 3 : delete "screensaver" extension permission #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -453 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +0 lines, -6 lines 0 comments Download
chrome/browser/chromeos/screensaver/screensaver_controller.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/chromeos/screensaver/screensaver_controller.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D chrome/browser/chromeos/screensaver/screensaver_controller_browsertest.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_power_manager_client.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/power_manager_client.h View 3 chunks +0 lines, -14 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 5 chunks +0 lines, -46 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Daniel Erat
7 years, 2 months ago (2013-10-15 21:51:41 UTC) #1
stevenjb
Can/should we remove APIPermission::kScreensaver also? Or do we want to install any existing such extensions?
7 years, 2 months ago (2013-10-15 22:02:46 UTC) #2
Daniel Erat
Good question. Maybe KioskModeScreensaver still depends on the permission -- Rahul?
7 years, 2 months ago (2013-10-15 22:04:25 UTC) #3
rkc
Screensaver removal LGTM after removal of the kScreensaver permission from, common/extensions/permissions/chrome_api_permissions.cc common/extensions/permissions/permission_set_unittest.cc extensions/common/permissions/api_permission.h
7 years, 2 months ago (2013-10-15 22:08:13 UTC) #4
rkc
On 2013/10/15 22:04:25, Daniel Erat wrote: > Good question. Maybe KioskModeScreensaver still depends on the ...
7 years, 2 months ago (2013-10-15 22:09:36 UTC) #5
Daniel Erat
delete "screensaver" extension permission
7 years, 2 months ago (2013-10-15 22:11:12 UTC) #6
stevenjb
Yay code removal. LGTM
7 years, 2 months ago (2013-10-15 22:28:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/26800005/15001
7 years, 2 months ago (2013-10-15 23:16:34 UTC) #8
Daniel Erat
TBR yoz@ for permission removal
7 years, 2 months ago (2013-10-15 23:22:33 UTC) #9
Daniel Erat
TBR yoz@ for permission removal (and emailing him this time too)
7 years, 2 months ago (2013-10-15 23:22:55 UTC) #10
Yoyo Zhou
permission removal LGTM
7 years, 2 months ago (2013-10-15 23:29:59 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-10-16 01:52:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/26800005/15001
7 years, 2 months ago (2013-10-16 13:46:50 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 13:47:16 UTC) #14
Message was sent while issue was closed. 
Change committed as 228911

Powered by Google App Engine
This is Rietveld 408576698