Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2679933002: Update URI related documentation and examples. (Closed)

Created:
3 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update URI related documentation and examples. Adds a test for all the examples. Fixes issues: #28659, #28660, #28661 BUG= http://dartbug.com/28659, http://dartbug.com/28660, http://dartbug.com/28661 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/d4a1e0689216c6bd013b6f97e0ea255e1f134b9f

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't escape backslashes in code-quotes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -20 lines) Patch
M sdk/lib/core/uri.dart View 1 8 chunks +22 lines, -20 lines 0 comments Download
A tests/corelib/uri_example_test.dart View 1 chunk +96 lines, -0 lines 0 comments Download
M tests/corelib/uri_file_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-07 10:00:10 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2679933002/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/2679933002/diff/1/sdk/lib/core/uri.dart#newcode189 sdk/lib/core/uri.dart:189: * except if the path starts with `\\\\?\\` ...
3 years, 10 months ago (2017-02-07 10:47:15 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/2679933002/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/2679933002/diff/1/sdk/lib/core/uri.dart#newcode189 sdk/lib/core/uri.dart:189: * except if the path starts with `\\\\?\\` in ...
3 years, 10 months ago (2017-02-07 10:54:31 UTC) #4
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-07 10:54:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d4a1e0689216c6bd013b6f97e0ea255e1f134b9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698