Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2679913006: Add KernelNativeBehaviorComputer (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add KernelNativeBehaviorComputer - to support NativeBehavior computation from KernelWorldBuilder. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/68b1c1a827b0c59e869439e78d9d167a7cdfd814

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -117 lines) Patch
M pkg/compiler/lib/src/kernel/element_adapter.dart View 1 2 8 chunks +149 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 2 11 chunks +187 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 4 chunks +11 lines, -55 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 5 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-08 14:40:25 UTC) #2
Johnni Winther
ping
3 years, 10 months ago (2017-02-09 11:13:48 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-09 20:31:51 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as 68b1c1a827b0c59e869439e78d9d167a7cdfd814 (presubmit successful).
3 years, 10 months ago (2017-02-10 09:36:44 UTC) #6
Emily Fortuna
On 2017/02/10 09:36:44, Johnni Winther wrote: > Committed patchset #3 (id:40001) manually as > 68b1c1a827b0c59e869439e78d9d167a7cdfd814 ...
3 years, 10 months ago (2017-02-13 19:33:02 UTC) #7
Johnni Winther
3 years, 10 months ago (2017-02-14 08:04:02 UTC) #8
Message was sent while issue was closed. 
On 2017/02/13 19:33:02, Emily Fortuna wrote:
> On 2017/02/10 09:36:44, Johnni Winther wrote:
> > Committed patchset #3 (id:40001) manually as
> > 68b1c1a827b0c59e869439e78d9d167a7cdfd814 (presubmit successful).
> 
> Hey Johnni,
> This broke another handful of Kernel tests (20 some) 
> 
> The error being: 
> sdk/lib/_internal/js_runtime/lib/native_typed_data.dart:1180:3:
> Error: Type 'NativeUint8List' not found.
> 
> Try running 
> python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960 --use-sdk
> --dart2js-batch --dart2js-options --use-kernel corelib/list_test
> or 
> python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960 --use-sdk
> --dart2js-batch --dart2js-options --use-kernel corelib/iterable_fold_test
> as an example of this failure.

It seems already to have been fixed in
https://codereview.chromium.org/2686243004/

Powered by Google App Engine
This is Rietveld 408576698