Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 26799004: SkRectShaderImageFilter: add a workaround for the zero-sized rects currently passed by Blink. Add … (Closed)

Created:
7 years, 2 months ago by Stephen White
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SkRectShaderImageFilter: add a workaround for the zero-sized rects currently passed by Blink. BUG=306488 R=robertphillips@google.com, robertphillips Committed: https://code.google.com/p/skia/source/detail?r=11733

Patch Set 1 #

Patch Set 2 : Revert the new API; keep just the workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/effects/SkRectShaderImageFilter.cpp View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
reed@: PTAL. Thanks!
7 years, 2 months ago (2013-10-11 15:34:25 UTC) #1
Stephen White
7 years, 2 months ago (2013-10-11 17:07:44 UTC) #2
robertphillips
lgtm - is this going to be permanent?
7 years, 2 months ago (2013-10-11 17:22:22 UTC) #3
Stephen White
On 2013/10/11 17:22:22, robertphillips wrote: > lgtm - is this going to be permanent? The ...
7 years, 2 months ago (2013-10-11 17:31:06 UTC) #4
Stephen White
On 2013/10/11 17:31:06, Stephen White wrote: > On 2013/10/11 17:22:22, robertphillips wrote: > > lgtm ...
7 years, 2 months ago (2013-10-11 17:55:18 UTC) #5
Stephen White
7 years, 2 months ago (2013-10-11 17:57:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r11733 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698