Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 26799002: Removed unused copy of app_list_shower_unittest. (Closed)

Created:
7 years, 2 months ago by Matt Giuca
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removed unused copy of app_list_shower_unittest. BUG=305921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -159 lines) Patch
D chrome/browser/ui/views/app_list/test/app_list_shower_unittest.cc View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Giuca
7 years, 2 months ago (2013-10-10 07:37:17 UTC) #1
koz (OOO until 15th September)
lgtm nit: "redundant" and "unused" are synonyms here, so you only need one of them.
7 years, 2 months ago (2013-10-10 07:38:41 UTC) #2
Matt Giuca
Good nit.
7 years, 2 months ago (2013-10-10 08:40:07 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-10 09:06:33 UTC) #4
koz (OOO until 15th September)
On 2013/10/10 08:40:07, Matt Giuca wrote: > Good nit. I was just kidding! The original ...
7 years, 2 months ago (2013-10-10 19:08:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/26799002/1
7 years, 2 months ago (2013-10-10 22:44:29 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 00:33:35 UTC) #7
Message was sent while issue was closed.
Change committed as 228063

Powered by Google App Engine
This is Rietveld 408576698