[Media Router] Add ProvideSinks() Mojo API

chrome/browser/media/router/media_router.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_H_
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/callback_list.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "chrome/browser/media/router/issue.h"
 #include "chrome/browser/media/router/media_route.h"
 #include "chrome/browser/media/router/media_sink.h"
+#include "chrome/browser/media/router/media_sink_internal.h"
 #include "chrome/browser/media/router/media_source.h"
 #include "chrome/browser/media/router/route_message_observer.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "content/public/browser/presentation_service_delegate.h"
 
 namespace content {
 class WebContents;
 }
 
 namespace url {
@@ skipping 26 matching lines @@
     const content::PresentationConnectionStateChangeInfo&)>::Subscription;
 
 // An interface for handling resources related to media routing.
 // Responsible for registering observers for receiving sink availability
 // updates, handling route requests/responses, and operating on routes (e.g.
 // posting messages or closing).
 // TODO(imcheng): Reduce number of parameters by putting them into structs.
 class MediaRouter : public KeyedService {
  public:
   using SendRouteMessageCallback = base::Callback<void(bool sent)>;
+  using MediaSinkList = std::vector<MediaSinkInternal>;

[mark a. foltz, 2017/03/01 06:31:43]

Nit: For consistency with other APIs, use std::vector explicitly instead of
using.

[zhaobin, 2017/03/02 20:24:04]

Done.

 
   ~MediaRouter() override = default;
 
   // Creates a media route from |source_id| to |sink_id|.
   // |origin| is the origin of requestor's page.
   // |web_contents| is the WebContents of the tab in which the request was made.
   // |origin| and |web_contents| are used for enforcing same-origin and/or
   // same-tab scope for JoinRoute() requests. (e.g., if enforced, the page
   // requesting JoinRoute() must have the same origin as the page that requested
   // CreateRoute()).
@@ skipping 89 matching lines @@
   // the user has no domain or is not signed in.  |sink_callback| will be called
   // either with the ID of the new sink when it is found or with an empty string
   // if no sink was found.
   virtual void SearchSinks(
       const MediaSink::Id& sink_id,
       const MediaSource::Id& source_id,
       const std::string& search_input,
       const std::string& domain,
       const MediaSinkSearchResponseCallback& sink_callback) = 0;
 
+  // Called when DIAL or CAST MediaSinkService finishes sink discovery.

[imcheng, 2017/03/01 23:28:36]

How about:

Notifies the Media Router that the list of MediaSinks discovered by a
MediaSinkService has been updated.
|provider_name|: Name of the MediaSinkService providing the sinks.
...

[zhaobin, 2017/03/02 20:24:04]

Done.

+  // |sinks|: sinks discovered by MediaSinkService.
+  virtual void ProvideSinks(const std::string& provider_name,
+                            const MediaSinkList& sinks) = 0;
+
   // Adds |callback| to listen for state changes for presentation connected to
   // |route_id|. The returned Subscription object is owned by the caller.
   // |callback| will be invoked whenever there are state changes, until the
   // caller destroys the Subscription object.
   virtual std::unique_ptr<PresentationConnectionStateSubscription>
   AddPresentationConnectionStateChangedCallback(
       const MediaRoute::Id& route_id,
       const content::PresentationConnectionStateChangedCallback& callback) = 0;
 
   // Called when the incognito profile for this instance is being shut down.
@@ skipping 60 matching lines @@
 
   // Unregisters a previously registered RouteMessagesObserver. |observer| will
   // stop receiving further updates.
   virtual void UnregisterRouteMessageObserver(
       RouteMessageObserver* observer) = 0;
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_H_