Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 267973002: Revert of Remove webkit's ResourceLoaderBridge interface. (Closed)

Created:
6 years, 7 months ago by DaleCurtis
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, Avi (use Gerrit), jochen (gone - plz use gerrit), darin (slow to review), pilgrim_google, jamesr
Visibility:
Public.

Description

Revert of Remove webkit's ResourceLoaderBridge interface. (https://codereview.chromium.org/226273005/) Reason for revert: Looks like it broke LSan bots: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2229 TBR=jam NOTREECHECKS=true NOTRY=true Original issue's description: > Remove webkit's ResourceLoaderBridge interface. > > ResourceLoaderBridge was originally created to bridge code in //webkit that > talked to WebURLLoaderImpl (which talked to Blink) with code in > ResourceDispatcher in content which used IPC. Now that WebURLLoaderImpl > is in content/child, we don't need this interface anymore. > > As requested by John in - > https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode42 > > BUG=265753, 338338, 237249 > TEST=content_unittests > R=jam@chromium.org > TBR=darin > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267947 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -284 lines) Patch
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/security_filter_peer.h View 5 chunks +23 lines, -11 lines 0 comments Download
M chrome/renderer/security_filter_peer.cc View 5 chunks +23 lines, -12 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/child_thread.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 5 chunks +16 lines, -24 lines 0 comments Download
M content/child/resource_dispatcher.h View 8 chunks +46 lines, -49 lines 0 comments Download
M content/child/resource_dispatcher.cc View 20 chunks +236 lines, -127 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 5 chunks +30 lines, -26 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 14 chunks +38 lines, -34 lines 0 comments Download
A webkit/child/resource_loader_bridge.h View 1 chunk +86 lines, -0 lines 0 comments Download
A webkit/child/resource_loader_bridge.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
Created Revert of Remove webkit's ResourceLoaderBridge interface.
6 years, 7 months ago (2014-05-03 01:50:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/267973002/1
6 years, 7 months ago (2014-05-03 01:50:35 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 01:50:35 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-03 01:50:36 UTC) #4
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-03 01:52:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/267973002/1
6 years, 7 months ago (2014-05-03 01:54:02 UTC) #6
DaleCurtis
The CQ bit was unchecked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-03 01:54:58 UTC) #7
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-03 01:55:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/267973002/1
6 years, 7 months ago (2014-05-03 01:55:51 UTC) #9
DaleCurtis
Stupid revert is trying to CQ, added appropriate commit message-fu.
6 years, 7 months ago (2014-05-03 01:56:26 UTC) #10
commit-bot: I haz the power
Change committed as 267999
6 years, 7 months ago (2014-05-03 01:57:12 UTC) #11
tfarina
6 years, 7 months ago (2014-05-03 02:04:59 UTC) #12
Message was sent while issue was closed.
OK, thanks.

Sorry for the breakage.

Powered by Google App Engine
This is Rietveld 408576698