Issue 267963004: Remove all the duplicate macros and types in command_buffer/common/types.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267963004: Remove all the duplicate macros and types in command_buffer/common/types.h. (Closed)

Created:
6 years, 7 months ago by Nico

Modified:
6 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove all the duplicate macros and types in command_buffer/common/types.h. (The motivation is that base's COMPILE_ASSERT uses static_assert if available, while this file's COMPILE_ASSERT didn't.) BUG=321833 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268123

Patch Set 1 #

Patch Set 2 : basebranch #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -184 lines)			Patch
M	gpu/command_buffer/common/cmd_buffer_common.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/common/types.h	View	1 chunk	+4 lines, -176 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

I think I remember you telling me that there's no reason anymore why this shouldn't ...

6 years, 7 months ago (2014-05-04 05:12:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/267963004/20001

6 years, 7 months ago (2014-05-04 20:15:05 UTC) #4

Message was sent while issue was closed.

Change committed as 268123

Expand Messages | Collapse Messages