Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: net/url_request/url_request_simple_job.cc

Issue 2679583004: Use TaskScheduler instead of WorkerPool in url_request_simple_job.cc. (Closed)
Patch Set: private last Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_simple_job.h ('k') | net/url_request/url_request_simple_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_simple_job.cc
diff --git a/net/url_request/url_request_simple_job.cc b/net/url_request/url_request_simple_job.cc
index 4f8b01ab3a7ca29de1ebf9c097e46ba72980afe9..6ec37c597911c4a8f380858d0a057ccb0d5e894d 100644
--- a/net/url_request/url_request_simple_job.cc
+++ b/net/url_request/url_request_simple_job.cc
@@ -11,6 +11,7 @@
#include "base/location.h"
#include "base/memory/ref_counted_memory.h"
#include "base/single_thread_task_runner.h"
+#include "base/task_scheduler/post_task.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/threading/worker_pool.h"
#include "net/base/io_buffer.h"
@@ -36,7 +37,6 @@ URLRequestSimpleJob::URLRequestSimpleJob(URLRequest* request,
NetworkDelegate* network_delegate)
: URLRangeRequestJob(request, network_delegate),
next_data_offset_(0),
- task_runner_(base::WorkerPool::GetTaskRunner(false)),
weak_factory_(this) {
}
@@ -71,20 +71,18 @@ int URLRequestSimpleJob::ReadRawData(IOBuffer* buf, int buf_size) {
if (buf_size == 0)
return 0;
- // Do memory copy on a background thread. See crbug.com/422489.
- GetTaskRunner()->PostTaskAndReply(
- FROM_HERE, base::Bind(&CopyData, make_scoped_refptr(buf), buf_size, data_,
- next_data_offset_),
+ // Do memory copy asynchronously. See crbug.com/422489.
xunjieli 2017/02/10 16:30:19 Please edit this comment per previous comment. "D
fdoray 2017/02/13 15:37:51 Done.
+ base::PostTaskWithTraitsAndReply(
+ FROM_HERE, base::TaskTraits().WithShutdownBehavior(
+ base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN),
+ base::Bind(&CopyData, make_scoped_refptr(buf), buf_size, data_,
+ next_data_offset_),
base::Bind(&URLRequestSimpleJob::ReadRawDataComplete,
weak_factory_.GetWeakPtr(), buf_size));
next_data_offset_ += buf_size;
return ERR_IO_PENDING;
}
-base::TaskRunner* URLRequestSimpleJob::GetTaskRunner() const {
- return task_runner_.get();
-}
-
int URLRequestSimpleJob::GetData(std::string* mime_type,
std::string* charset,
std::string* data,
« no previous file with comments | « net/url_request/url_request_simple_job.h ('k') | net/url_request/url_request_simple_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698