Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2679553003: [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/2ee2fe9b5c7c47bedf38ebdb7c270070f2f6f869

Patch Set 1 #

Patch Set 2 : add analyzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +3 lines, -0 lines 0 comments Download
M samples/samples.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/kernel/kernel.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This doesn't disable everything, but will make it easier to see what I've missed.
3 years, 10 months ago (2017-02-06 20:29:26 UTC) #2
Bill Hesse
LGTM.
3 years, 10 months ago (2017-02-06 20:34:59 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-06 21:26:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ee2fe9b5c7c47bedf38ebdb7c270070f2f6f869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698