Added unit test for WebShareTargetPickerView.

chrome/browser/ui/views/webshare/webshare_target_picker_view.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/webshare/webshare_target_picker_view.h"
 
 #include "chrome/grit/generated_resources.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 29 matching lines @@
   views::BoxLayout* layout = new views::BoxLayout(
       views::BoxLayout::kVertical, views::kPanelHorizMargin,
       views::kPanelVertMargin, views::kRelatedControlVerticalSpacing);
   SetLayoutManager(layout);
 
   views::Label* overview_label = new views::Label(
       l10n_util::GetStringUTF16(IDS_WEBSHARE_TARGET_PICKER_LABEL));
   AddChildView(overview_label);
 
   std::vector<ui::TableColumn> table_columns{ui::TableColumn()};
-  views::TableView* table =
-      new views::TableView(this, table_columns, views::TEXT_ONLY, true);
+  table_ = new views::TableView(this, table_columns, views::TEXT_ONLY, true);

[sky, 2017/02/06 17:11:24]

To avoid errors please initialize table_ to null in the member initializer list.

[Matt Giuca, 2017/02/06 23:17:21]

Done (in the .h file).

   // Select the first row.
   if (RowCount() > 0)
-    table->Select(0);
+    table_->Select(0);
 
   // Create the table parent (a ScrollView which includes the scroll bars and
   // border). We add this parent (not the table itself) to the dialog.
-  views::View* table_parent = table->CreateParentIfNecessary();
+  views::View* table_parent = table_->CreateParentIfNecessary();
   AddChildView(table_parent);
   // Make the table expand to fill the space.
   layout->SetFlexForView(table_parent, 1);
 }
 
 WebShareTargetPickerView::~WebShareTargetPickerView() {}
 
 gfx::Size WebShareTargetPickerView::GetPreferredSize() const {
   return gfx::Size(kDialogWidth, kDialogHeight);
 }
@@ skipping 30 matching lines @@
 
 int WebShareTargetPickerView::RowCount() {
   return targets_.size();
 }
 
 base::string16 WebShareTargetPickerView::GetText(int row, int /*column_id*/) {
   return targets_[row];
 }
 
 void WebShareTargetPickerView::SetObserver(ui::TableModelObserver* observer) {}