Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 267953002: Port ui_base_test_support target GN build. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, blundell, Ben Goodger (Google)
Visibility:
Public.

Description

Port ui_base_test_support target GN build. In Debug config: $ gn gen out/Debug_gn $ ninja -C out/Debug_gn ui_base_test_support In Release config: $ gn gen out/Release_gn --args='is_debug=false' $ ninja -C out/Release_gn ui_base_test_support BUG=None TEST=see above R=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M ui/base/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 7 months ago (2014-05-02 23:36:36 UTC) #1
brettw
lgtm
6 years, 7 months ago (2014-05-02 23:39:53 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-04 18:18:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/267953002/1
6 years, 7 months ago (2014-05-04 18:18:22 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-04 18:50:44 UTC) #5
Message was sent while issue was closed.
Change committed as 268117

Powered by Google App Engine
This is Rietveld 408576698