Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

Issue 2679483002: DevTools: Create extensible QuickOpen control (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
index c17bec987eae998334af9c39e8d82fa4d29c02f0..75a0b0914037c24a059ddae93a12cd46e429a944 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
@@ -3,7 +3,6 @@ function test() {
TestRunner.addResult("Check to see that FilteredItemSelectionDialog uses proper regex to filter results.");
var overridenInput = [];
- var overrideShowMatchingItems = true;
var history = [];
var StubDelegate = class extends QuickOpen.FilteredListWidget.Delegate {
@@ -14,15 +13,13 @@ function test() {
{
TestRunner.addResult("Selected item index: " + itemIndex);
}
- shouldShowMatchingItems () { return overrideShowMatchingItems; }
};
var delegate = new StubDelegate();
- function checkQuery(query, input, hideMatchingItems)
+ function checkQuery(query, input)
{
overridenInput = input;
- overrideShowMatchingItems = !hideMatchingItems;
TestRunner.addResult("Input:" + JSON.stringify(input));
@@ -67,22 +64,22 @@ function test() {
return checkQuery("ab", ["abc", "bac", "a_B"]);
},
- function dumplicateSymbolsInQuery(next)
+ function dumplicateSymbolsInQuery()
{
return checkQuery("aab", ["abab", "abaa", "caab", "baac", "fooaab"]);
},
- function dangerousInputEscaping(next)
+ function dangerousInputEscaping()
{
return checkQuery("^[]{}()\\.$*+?|", ["^[]{}()\\.$*+?|", "0123456789abcdef"]);
},
- function itemIndexIsNotReportedInGoToLine(next)
+ function itemIndexIsNotReportedInGoToLine()
{
- return checkQuery(":1", [":1:2:3.js"], true, next);
+ return checkQuery(":1", []);
},
- function autoCompleteIsLast(next)
+ function autoCompleteIsLast()
{
return checkQuery("", ["abc", "abcd"]);
}

Powered by Google App Engine
This is Rietveld 408576698