DevTools: Create extensible QuickOpen control

third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

 /*
  * Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
-/**
- * @unrestricted
- */
-Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListProvider {
+Sources.OpenFileQuickOpen = class extends Sources.FilteredUISourceCodeListProvider {
   /**
-   * @param {!Sources.SourcesView} sourcesView
-   * @param {!Map.<!Workspace.UISourceCode, number>} defaultScores
+   * @override
    */
-  constructor(sourcesView, defaultScores) {
-    super(defaultScores);
-    this._sourcesView = sourcesView;
+  attach() {
+    this.setDefaultScores(Sources.SourcesView.defaultUISourceCodeScores());

[einbinder, 2017/03/08 22:39:57]

I removed the caching of providers in QuickOpen.js. Instead the providers are
cached by the runtime system. In order to re-use the same provider, I pass in
the current scores on attach instead of in  the constructor. 

+    super.attach();
   }
 
   /**
-   * @param {!Sources.SourcesView} sourcesView
-   * @param {string} query
-   * @param {!Map.<!Workspace.UISourceCode, number>} defaultScores
-   * @param {!Array<string>} history
-   */
-  static show(sourcesView, query, defaultScores, history) {
-    var dialog = new Sources.OpenResourceDialog(sourcesView, defaultScores);
-    if (InspectorFrontendHost.isUnderTest())
-      Sources.OpenResourceDialog._instanceForTest = dialog;
-    var filteredItemSelectionDialog = new QuickOpen.FilteredListWidget(dialog, history);
-    filteredItemSelectionDialog.showAsDialog();
-    filteredItemSelectionDialog.setQuery(query);
-  }
-
-  /**
    * @override
    * @param {?Workspace.UISourceCode} uiSourceCode
    * @param {number=} lineNumber
    * @param {number=} columnNumber
    */
   uiSourceCodeSelected(uiSourceCode, lineNumber, columnNumber) {
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.SelectFileFromFilePicker);
 
     if (!uiSourceCode)
-      uiSourceCode = this._sourcesView.currentUISourceCode();
-    if (!uiSourceCode)
       return;
-    this._sourcesView.showSourceLocation(uiSourceCode, lineNumber, columnNumber);
+    Common.Revealer.reveal(uiSourceCode.uiLocation((lineNumber || 0), columnNumber));
   }
 
   /**
-   * @override
-   * @param {string} query
-   * @return {boolean}
-   */
-  shouldShowMatchingItems(query) {
-    return !query.startsWith(':');
-  }
-
-  /**
    * @override
    * @param {!Workspace.Project} project
    * @return {boolean}
    */
   filterProject(project) {
     return !project.isServiceProject();
   }
 
   /**
    * @override
    * @return {boolean}
    */
   renderAsTwoRows() {
     return true;
   }
 };
 
-
-/**
- * @unrestricted
- */
 Sources.SelectUISourceCodeForProjectTypesDialog = class extends Sources.FilteredUISourceCodeListProvider {
   /**
    * @param {!Array.<string>} types
    * @param {function(?Workspace.UISourceCode)} callback
    */
   constructor(types, callback) {
     super();
     this._types = types;
     this._callback = callback;
   }
@@ skipping 30 matching lines @@
   }
 
   /**
    * @override
    * @return {boolean}
    */
   renderAsTwoRows() {
     return true;
   }
 };