Defer NetworkConfigurationHandler::CreateShillConfiguration callback

chromeos/network/network_configuration_handler.h

Index: chromeos/network/network_configuration_handler.h
diff --git a/chromeos/network/network_configuration_handler.h b/chromeos/network/network_configuration_handler.h
index b780ce53c2e85beb84da8273abd7f9f2ee45bb4a..c518c750ad82c384a81d4e85cac67612f933ab97 100644
--- a/chromeos/network/network_configuration_handler.h
+++ b/chromeos/network/network_configuration_handler.h
@@ -20,6 +20,7 @@
 #include "chromeos/network/network_configuration_observer.h"
 #include "chromeos/network/network_handler.h"
 #include "chromeos/network/network_handler_callbacks.h"
+#include "chromeos/network/network_state_handler_observer.h"
 
 namespace base {
 class DictionaryValue;
@@ -55,9 +56,9 @@ namespace chromeos {
 // user consumption.  Both |callback| and |error_callback| are permitted to be
 // null callbacks.
 class CHROMEOS_EXPORT NetworkConfigurationHandler
-    : public base::SupportsWeakPtr<NetworkConfigurationHandler> {
+    : public NetworkStateHandlerObserver {
  public:
-  ~NetworkConfigurationHandler();
+  ~NetworkConfigurationHandler() override;
 
   // Manages the observer list.
   void AddObserver(NetworkConfigurationObserver* observer);
@@ -122,6 +123,9 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
                          const base::Closure& callback,
                          const network_handler::ErrorCallback& error_callback);
 
+  // NetworkStateHandlerObserver
+  void NetworkListChanged() override;
+
   // Construct and initialize an instance for testing.
   static NetworkConfigurationHandler* InitializeForTest(
       NetworkStateHandler* network_state_handler,
@@ -138,7 +142,9 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
   void Init(NetworkStateHandler* network_state_handler,
             NetworkDeviceHandler* network_device_handler);
 
-  void RunCreateNetworkCallback(
+  // Called when a configuration completes. This will wait for the cahced

[tbarzic, 2017/02/10 19:20:04]

typo: cahced

[stevenjb, 2017/02/10 21:04:17]

Thanks, sorry done.

+  // state (NetworkStateHandler) to update before triggering the callback.
+  void ConfigurationCompleted(
       const std::string& profile_path,
       NetworkConfigurationObserver::Source source,
       std::unique_ptr<base::DictionaryValue> configure_properties,
@@ -206,8 +212,15 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
   std::map<std::string, std::unique_ptr<ProfileEntryDeleter>>
       profile_entry_deleters_;
 
+  // Map of configuraiton callbacks to run once the service becomes available

[tbarzic, 2017/02/10 19:20:04]

typo: configuraiton

[stevenjb, 2017/02/10 21:04:17]

Done.

+  // in the NetworkStateHandler cache.
+  std::map<std::string, network_handler::ServiceResultCallback>
+      configure_callbacks_;
+
   base::ObserverList<NetworkConfigurationObserver, true> observers_;
 
+  base::WeakPtrFactory<NetworkConfigurationHandler> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(NetworkConfigurationHandler);
 };