third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py - Issue 2679393004: Fix all "dangerous-default-value" pylint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

Issue 2679393004: Fix all "dangerous-default-value" pylint warnings. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

index 5cf8ca4bb761c6a4dbe651018db891dee6c02038..1a1afae9d94b2da7b65cc6529589621089b58d24 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

@@ -52,7 +52,7 @@ def get_result(test_name, result_type=test_expectations.PASS, run_time=0):

return test_results.TestResult(test_name, failures=failures, test_run_time=run_time)

-def run_results(port, extra_skipped_tests=[]):

+def run_results(port, extra_skipped_tests=None):

tests = [

'passes/text.html',

'failures/expected/timeout.html',

@@ -69,7 +69,7 @@ def run_results(port, extra_skipped_tests=[]):

return test_run_results.TestRunResults(expectations, len(tests))

-def summarized_results(port, expected, passing, flaky, only_include_failing=False, extra_skipped_tests=[], fail_on_retry=False):

+def summarized_results(port, expected, passing, flaky, only_include_failing=False, extra_skipped_tests=None):

test_is_slow = False

all_retry_results = []

@@ -402,8 +402,7 @@ class SummarizedResultsTest(unittest.TestCase):

self.assertEquals(summary['num_regressions'], 0)

def test_summarized_results_regression(self):

- summary = summarized_results(self.port, expected=False, passing=False,

- flaky=False, fail_on_retry=True)

+ summary = summarized_results(self.port, expected=False, passing=False, flaky=False)

self.assertTrue(summary['tests']['failures']['expected']['timeout.html']['is_unexpected'])

self.assertEquals(summary['tests']['failures']['expected']['timeout.html']['expected'], 'TIMEOUT')