Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2679373003: Compute also constant dependencies reference in method bodies. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute also constant dependencies reference in method bodies. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8bc597f04bd35528658139442109dd099ab32048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-08 02:50:22 UTC) #1
Brian Wilkerson
lgtm, but I'm surprised that there are no tests...
3 years, 10 months ago (2017-02-08 14:47:42 UTC) #2
scheglov
3 years, 10 months ago (2017-02-08 16:38:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8bc597f04bd35528658139442109dd099ab32048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698