Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: ui/gfx/animation/slide_animation.h

Issue 2679333002: [ash-md] Remove the number of animators used for the Shelf animations. (Closed)
Patch Set: Addressed review comments and updated ShelfBackgroundAnimator::animator_ lifetime. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/animation/slide_animation.h
diff --git a/ui/gfx/animation/slide_animation.h b/ui/gfx/animation/slide_animation.h
index 9023d40c86f3de320cdc089d497347af363421fd..02ebda7c59d4cf94aeaeca0f8f4bed74ab8da377 100644
--- a/ui/gfx/animation/slide_animation.h
+++ b/ui/gfx/animation/slide_animation.h
@@ -68,6 +68,10 @@ class GFX_EXPORT SlideAnimation : public LinearAnimation {
void SetTweenType(Tween::Type tween_type) { tween_type_ = tween_type; }
double GetCurrentValue() const override;
+ // TODO(bruthig): Fix IsShowing() and IsClosing() to be consistent. e.g.
+ // IsShowing() will currently return true after the 'show' animation has been
+ // completed however IsClosing() will return false after the 'hide' animation
+ // has been completed.
bool IsShowing() const { return showing_; }
bool IsClosing() const { return !showing_ && value_end_ < value_current_; }

Powered by Google App Engine
This is Rietveld 408576698