chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm - Issue 2679273002: [Mac] Retain location bar focus on switching to fullscreen and back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 2679273002: [Mac] Retain location bar focus on switching to fullscreen and back. (Closed)

Patch Set: Fix regression with the toolbar not dropping down. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

index 4b3458fac407a81c9f27e281e8656f02a3389b5e..e154518fd0036715e557876be11298b787d25c71 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

@@ -576,6 +576,11 @@ class NotificationBridge : public AppMenuIconController::Delegate {

locationBarView_->OnAddedToWindow();

}

+- (BOOL)locationBarHasFocus {

+ return [[autocompleteTextFieldEditor_ window] firstResponder] ==

+ autocompleteTextFieldEditor_.get();

- (void)focusLocationBar:(BOOL)selectAll {

if (locationBarView_.get()) {

locationBarView_->FocusLocation(selectAll ? true : false);