Issue 2679243002: Make fields private, add DeclaredVariables, put library into a field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2679243002: Make fields private, add DeclaredVariables, put library into a field. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -66 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart	View	1	20 chunks	+66 lines, -62 lines	0 comments	Download
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-02-07 19:18:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
be37e10b7262aea86c667e54dd410878460cc50d (presubmit successful).