editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java - Issue 267923004: Check const map literal keys and switch case exprs using type of constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java

Issue 267923004: Check const map literal keys and switch case exprs using type of constant. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/ResolveDartUnitTask.java » ('j') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java

index 40b4b6f33c7ecf90c15c60140e94c255c21f5038..5e682f579aadb539211f735d8a3516ccd5fe55e5 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartErrorsTask.java

@@ -197,7 +197,10 @@ public class GenerateDartErrorsTask extends AnalysisTask {

// Use the ConstantVerifier to verify the use of constants. This needs to happen before using

// the ErrorVerifier because some error codes need the computed constant values.

- ConstantVerifier constantVerifier = new ConstantVerifier(errorReporter, typeProvider);

+ ConstantVerifier constantVerifier = new ConstantVerifier(

+ errorReporter,

+ libraryElement,

+ typeProvider);

unit.accept(constantVerifier);

// Use the ErrorVerifier to compute the rest of the errors.