Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: Source/bindings/v8/custom/V8NodeListCustom.cpp

Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: mark NodeFilter Dependent Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8NodeListCustom.cpp
diff --git a/Source/bindings/v8/custom/V8NodeListCustom.cpp b/Source/bindings/v8/custom/V8NodeListCustom.cpp
index 479eadc19f5e58632e40cf7195c541c7f4402aff..20280a9134c98058979e8905bc85a8e8d3a1f3b1 100644
--- a/Source/bindings/v8/custom/V8NodeListCustom.cpp
+++ b/Source/bindings/v8/custom/V8NodeListCustom.cpp
@@ -41,15 +41,20 @@
namespace WebCore {
-void* V8NodeList::opaqueRootForGC(void* object, v8::Isolate* isolate)
+void V8NodeList::resolveWrapperReachability(void* object, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
{
NodeList* impl = static_cast<NodeList*>(object);
- if (!impl->isLiveNodeList())
- return object;
+ if (!impl->isLiveNodeList()) {
+ setObjectGroup(object, wrapper, isolate);
+ return;
+ }
Node* owner = static_cast<LiveNodeList*>(impl)->ownerNode();
- if (!owner)
- return object;
- return V8GCController::opaqueRootForGC(owner, isolate);
+ if (!owner) {
+ setObjectGroup(object, wrapper, isolate);
+ return;
+ }
+
+ setObjectGroup(V8GCController::opaqueRootForGC(owner, isolate), wrapper, isolate);
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8NodeIteratorCustom.cpp ('k') | Source/bindings/v8/custom/V8TreeWalkerCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698