Source/bindings/v8/V8GCController.cpp - Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8GCController.cpp

Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: create/check wrapper on creationContext Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8GCController.cpp

diff --git a/Source/bindings/v8/V8GCController.cpp b/Source/bindings/v8/V8GCController.cpp

index 14779ed5953c2c0ee2f87ea2e907b989f0b888b9..483d6480c733435afe8ee098cce49b29528bc2b1 100644

--- a/Source/bindings/v8/V8GCController.cpp

+++ b/Source/bindings/v8/V8GCController.cpp

@@ -284,8 +284,8 @@ public:

m_groupsWhichNeedRetainerInfo.append(root);

} else if (classId == v8DOMObjectClassId) {

ASSERT(!value->IsIndependent());

- void* root = type->opaqueRootForGC(object, m_isolate);

- m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));

+ v8::Persistent<v8::Object>* wrapperPersistent = reinterpret_cast<v8::Persistent<v8::Object>*>(value);

+ type->resolveWrapperReachability(object, *wrapperPersistent, m_isolate);

} else {

ASSERT_NOT_REACHED();

}