Source/bindings/v8/UnsafePersistent.h - Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/UnsafePersistent.h

Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/UnsafePersistent.h

diff --git a/Source/bindings/v8/UnsafePersistent.h b/Source/bindings/v8/UnsafePersistent.h

index 6f512a26f299e2689e08532e476710423266e52b..d1aa957472ce550f11db4cb370854f98e95934ac 100644

--- a/Source/bindings/v8/UnsafePersistent.h

+++ b/Source/bindings/v8/UnsafePersistent.h

@@ -88,6 +88,12 @@ public:

return handle;

}

+ void setReferenceFrom(const v8::Persistent<v8::Object>& parent, v8::Isolate* isolate)

+ {

+ // FIXME: remove As() after v8 roll.

+ isolate->SetReference(parent, persistent()->template As<v8::Value>());

+ }

void dispose()

{

persistent()->Dispose();