LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash.html - Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash.html

Issue 26792002: Reland: Reland: Implement new Blink IDL attribute [SetReference] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash-expected.txt » ('j') | Source/bindings/v8/DOMDataStore.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash.html

diff --git a/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html b/LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash.html

similarity index 66%

copy from LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

copy to LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash.html

index c3a1cb82aecb20f75abd700a5d5530ddb209cd1e..c5d07bb9af2f2f4fc40beb1ad174919192f012dd 100644

--- a/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

+++ b/LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash.html

@@ -3,6 +3,8 @@

<body>

+ jsTestIsAsync = true;

var callbackWasTriggered = false;

var callback = function(node) {

@@ -24,10 +26,17 @@

shouldBeTrue('callbackWasTriggered');

nodeIterator = null;

- gc();

- shouldBeTrue('nodeIteratorObservation.wasCollected');

- shouldBeTrue('nodeFilterObservation.wasCollected');

- shouldBeTrue('callbackObservation.wasCollected');

+ testRunner.evaluateScriptInIsolatedWorld(1, 'document.getElementById("body")'); // create a wrapper in isolated world

+ internals.garbageCollectV8WithoutContext();

+ setTimeout(function() {

+ shouldBeTrue('nodeIteratorObservation.wasCollected');

+ shouldBeTrue('nodeFilterObservation.wasCollected');

+ shouldBeTrue('callbackObservation.wasCollected');

+ finishJSTest();

+ }, 0);

</script>

</body>

« no previous file with comments | « no previous file | LayoutTests/fast/dom/NodeIterator/NodeIterator-gc-without-context-crash-expected.txt » ('j') | Source/bindings/v8/DOMDataStore.cpp » ('J')