Reland: Reland: Implement new Blink IDL attribute [SetReference]

Source/bindings/v8/V8GCController.cpp

Index: Source/bindings/v8/V8GCController.cpp
diff --git a/Source/bindings/v8/V8GCController.cpp b/Source/bindings/v8/V8GCController.cpp
index d19dd649becad2db10c0c165f3747546ff0cbde6..265ded47476dfc1eec3c4bab09c3e52e48f390a4 100644
--- a/Source/bindings/v8/V8GCController.cpp
+++ b/Source/bindings/v8/V8GCController.cpp
@@ -239,6 +239,7 @@ public:
             return;
 
         v8::Handle<v8::Object>* wrapper = reinterpret_cast<v8::Handle<v8::Object>*>(value);
+        v8::Persistent<v8::Object>* wrapperpers = reinterpret_cast<v8::Persistent<v8::Object>*>(value);

[haraken, 2013/10/10 06:08:32]

You can write this just before you use |wrapperpers|.

Also, please rename |wrapperpers| to something more descriptive.

 
         ASSERT(V8DOMWrapper::maybeDOMWrapper(*wrapper));
 
@@ -284,7 +285,7 @@ public:
                 m_groupsWhichNeedRetainerInfo.append(root);
         } else if (classId == v8DOMObjectClassId) {
             ASSERT(!value->IsIndependent());
-            void* root = type->opaqueRootForGC(object, m_isolate);
+            void* root = type->resolveWrapperReachability(object, *wrapperpers, m_isolate);
             m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));

[haraken, 2013/10/10 06:08:32]

This is a bit confusing. resolveWrapperReachability adds some reachability and
returns an opaque GC root. Then we're doing object grouping outside
resolveWrapperReachability.

Ideally I hope all reachability are handled in resolveWrapperReachability.

         } else {
             ASSERT_NOT_REACHED();