Reland: Reland: Implement new Blink IDL attribute [SetReference]

Source/bindings/v8/DOMDataStore.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 83 matching lines @@
                 v8::Handle<v8::Object> result = ScriptWrappable::getUnsafeWrapperFromObject(object).newLocal(isolate);
                 // Security: always guard against malicious tampering.
                 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(result.IsEmpty() || result->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex) == V8T::toInternalPointer(object));
                 return result;
             }
         }
         return current(isolate)->template get<V8T>(object, isolate);
     }
 
     template<typename V8T, typename T>
+    static void setWrapperReference(const v8::Persistent<v8::Object>& parent, T* child, v8::Isolate* isolate)

[haraken, 2013/10/29 01:14:53]

Since you're using "setWrapperReference" here...

+    {
+        if (ScriptWrappable::wrapperCanBeStoredInObject(child) && !canExistInWorker(child)) {
+            if (LIKELY(!DOMWrapperWorld::isolatedWorldsExist())) {
+                UnsafePersistent<v8::Object> unsafePersistent = ScriptWrappable::getUnsafeWrapperFromObject(child);
+                // Security: always guard against malicious tampering.
+                RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(unsafePersistent.isEmpty() || unsafePersistent.value()->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex) == V8T::toInternalPointer(child));
+                unsafePersistent.setReferenceFrom(parent, isolate);
+            }
+        }
+        current(isolate)->template setReference<V8T>(parent, child, isolate);

[haraken, 2013/10/29 01:14:53]

...shall we rename:

setReference => setWrapperReference

[SetReference] => [SetWrapperReference

?

[kouhei (in TOK), 2013/10/29 04:19:58]

I guess this issue is resolved from offline discussion.

The main logic is in "setReference" method. This method is named
set"Wrapper"Reference to follow naming convensions for static methods.

+    }
+
+    template<typename V8T, typename T>
     static void setWrapper(T* object, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate, const WrapperConfiguration& configuration)
     {
         if (ScriptWrappable::wrapperCanBeStoredInObject(object) && !canExistInWorker(object)) {
             if (LIKELY(!DOMWrapperWorld::isolatedWorldsExist())) {
                 ScriptWrappable::setWrapperInObject(object, wrapper, isolate, configuration);
                 return;
             }
         }
         return current(isolate)->template set<V8T>(object, wrapper, isolate, configuration);
     }
 
     template<typename V8T, typename T>
     static bool containsWrapper(T* object, v8::Isolate* isolate)
     {
         return current(isolate)->template containsWrapper<V8T>(object);
     }
 
     template<typename V8T, typename T>
     inline v8::Handle<v8::Object> get(T* object, v8::Isolate* isolate)
     {
         if (ScriptWrappable::wrapperCanBeStoredInObject(object) && m_type == MainWorld)
             return ScriptWrappable::getUnsafeWrapperFromObject(object).newLocal(isolate);
         return m_wrapperMap.newLocal(V8T::toInternalPointer(object), isolate);
     }
 
     template<typename V8T, typename T>
+    inline void setReference(const v8::Persistent<v8::Object>& parent, T* child, v8::Isolate* isolate)
+    {
+        if (ScriptWrappable::wrapperCanBeStoredInObject(child) && m_type == MainWorld) {
+            ScriptWrappable::getUnsafeWrapperFromObject(child).setReferenceFrom(parent, isolate);
+            return;
+        }
+        m_wrapperMap.setReference(parent, V8T::toInternalPointer(child), isolate);
+    }
+
+    template<typename V8T, typename T>
     inline bool setReturnValueFrom(v8::ReturnValue<v8::Value> returnValue, T* object)
     {
         if (ScriptWrappable::wrapperCanBeStoredInObject(object) && m_type == MainWorld)
             return ScriptWrappable::setReturnValue(returnValue, object);
         return m_wrapperMap.setReturnValueFrom(returnValue, V8T::toInternalPointer(object));
     }
 
     template<typename V8T, typename T>
     inline bool containsWrapper(T* object)
     {
@@ skipping 33 matching lines @@
         return holder == *unsafePersistent.persistent();
     }
 
     WrapperWorldType m_type;
     DOMWrapperMap<void> m_wrapperMap;
 };
 
 } // namespace WebCore
 
 #endif // DOMDataStore_h