Reland: Reland: Implement new Blink IDL attribute [SetReference]

Source/bindings/v8/custom/V8NodeIteratorCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 #include "config.h"
 #include "V8NodeIterator.h"
 
 #include "V8NodeFilter.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8HiddenPropertyName.h"
 #include "core/dom/Node.h"
 
 namespace WebCore {
 
-v8::Handle<v8::Object> wrap(NodeIterator* nodeIterator, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+void* V8NodeIterator::resolveWrapperReachability(void* object, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
 {
-    ASSERT(nodeIterator);
-    ASSERT(!DOMDataStore::containsWrapper<V8NodeIterator>(nodeIterator, isolate));
+    NodeIterator* impl = fromInternalPointer(object);
+    
+    NodeFilter* filter = impl->filter();
+    if (filter) {
+        toV8(filter, v8::Local<v8::Object>::New(isolate, wrapper), isolate);
+        isolate->SetReference(wrapper, *reinterpret_cast<v8::Persistent<v8::Value>*>(filter->unsafePersistent().persistent()));

[haraken, 2013/10/10 06:08:32]

 
*reinterpret_cast<v8::Persistent<v8::Value>*>(filter->unsafePersistent().persistent())

This is ugly. Can't we make it simpler?

+    }
 
-    v8::Handle<v8::Object> wrapper = V8NodeIterator::createWrapper(nodeIterator, creationContext, isolate);
-
-    if (nodeIterator->filter())
-        V8HiddenPropertyName::setNamedHiddenReference(wrapper, "filter", toV8(nodeIterator->filter(), creationContext, isolate));
-
-    return wrapper;
+    return object;
 }
 
 } // namespace WebCore