Reland: Reland: Implement new Blink IDL attribute [SetReference]

Source/bindings/v8/V8GCController.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 221 matching lines @@
     virtual void VisitPersistentHandle(v8::Persistent<v8::Value>* value, uint16_t classId) OVERRIDE
     {
         // Casting to a Handle is safe here, since the Persistent cannot get GCd
         // during the GC prologue.
         ASSERT((*reinterpret_cast<v8::Handle<v8::Value>*>(value))->IsObject());
 
         if (classId != v8DOMNodeClassId && classId != v8DOMObjectClassId)
             return;
 
         v8::Handle<v8::Object>* wrapper = reinterpret_cast<v8::Handle<v8::Object>*>(value);
+        v8::Persistent<v8::Object>* wrapperpers = reinterpret_cast<v8::Persistent<v8::Object>*>(value);

[haraken, 2013/10/10 06:08:32]

You can write this just before you use |wrapperpers|.

Also, please rename |wrapperpers| to something more descriptive.

 
         ASSERT(V8DOMWrapper::maybeDOMWrapper(*wrapper));
 
         if (value->IsIndependent())
             return;
 
         WrapperTypeInfo* type = toWrapperTypeInfo(*wrapper);
         void* object = toNative(*wrapper);
 
         if (V8MessagePort::info.equals(type)) {
@@ skipping 25 matching lines @@
             Node* node = static_cast<Node*>(object);
 
             if (node->hasEventListeners())
                 addReferencesForNodeWithEventListeners(m_isolate, node, v8::Persistent<v8::Object>::Cast(*value));
             Node* root = V8GCController::opaqueRootForGC(node, m_isolate);
             m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));
             if (m_constructRetainedObjectInfos)
                 m_groupsWhichNeedRetainerInfo.append(root);
         } else if (classId == v8DOMObjectClassId) {
             ASSERT(!value->IsIndependent());
-            void* root = type->opaqueRootForGC(object, m_isolate);
+            void* root = type->resolveWrapperReachability(object, *wrapperpers, m_isolate);
             m_isolate->SetObjectGroupId(*value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));

[haraken, 2013/10/10 06:08:32]

This is a bit confusing. resolveWrapperReachability adds some reachability and
returns an opaque GC root. Then we're doing object grouping outside
resolveWrapperReachability.

Ideally I hope all reachability are handled in resolveWrapperReachability.

         } else {
             ASSERT_NOT_REACHED();
         }
     }
 
     void notifyFinished()
     {
         if (!m_constructRetainedObjectInfos)
             return;
         std::sort(m_groupsWhichNeedRetainerInfo.begin(), m_groupsWhichNeedRetainerInfo.end());
@@ skipping 115 matching lines @@
 {
     v8::HandleScope handleScope(isolate);
     v8::Local<v8::Context> context = v8::Context::New(isolate);
     if (context.IsEmpty())
         return;
     v8::Context::Scope contextScope(context);
     V8ScriptRunner::compileAndRunInternalScript(v8String("if (gc) gc();", isolate), isolate);
 }
 
 }  // namespace WebCore