third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py - Issue 2679173005: Rename Host.scm -> Host.git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py

Issue 2679173005: Rename Host.scm -> Host.git. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py

index a679b915c5d3165ef0a6ba183534974f294c43c7..936eb3efe2fa2a016814cf44c637f5fbe4438b52 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py

@@ -114,12 +114,12 @@ class LayoutTestResults(object):

return self._results["builder_name"]

@memoized

- def chromium_revision(self, scm=None):

+ def chromium_revision(self, git=None):

"""Returns the revision of the results in commit position number format."""

revision = self._chromium_revision or self._results["chromium_revision"]

if not revision.isdigit():

- assert scm, "scm is required if the original revision is a git hash."

- revision = scm.commit_position_from_git_commit(revision)

+ assert git, "git is required if the original revision is a git hash."

+ revision = git.commit_position_from_git_commit(revision)

return int(revision)

def result_for_test(self, test):