third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp - Issue 2679093006: Add a use counter for RtcpMuxPolicy of "negotiate".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2679093006: Add a use counter for RtcpMuxPolicy of "negotiate". (Closed)

Patch Set: CR comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/Deprecation.cpp ('K') | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

index 85cb675df52591ff30a073a66e2606b8d9868286..0fc7b7ecdb7907f95e5ae75721da24793fdba919 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

@@ -46,6 +46,7 @@

#include "core/dom/Document.h"

#include "core/dom/ExceptionCode.h"

#include "core/dom/ExecutionContext.h"

+#include "core/frame/Deprecation.h"

#include "core/frame/HostsUsingFeatures.h"

#include "core/frame/LocalFrame.h"

#include "core/frame/UseCounter.h"

@@ -264,6 +265,7 @@ WebRTCConfiguration parseConfiguration(ExecutionContext* context,

String rtcpMuxPolicyString = configuration.rtcpMuxPolicy();

if (rtcpMuxPolicyString == "negotiate") {

rtcpMuxPolicy = WebRTCRtcpMuxPolicy::kNegotiate;

+ Deprecation::countDeprecation(context, UseCounter::RtcpMuxPolicyNegotiate);

} else {

DCHECK_EQ(rtcpMuxPolicyString, "require");

}