Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 267903005: [Android] Ignore isSystemKey from the framework. (Closed)

Created:
6 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, benm (inactive)
Visibility:
Public.

Description

[Android] Ignore isSystemKey from the framework. Force isSystemKey flag to false as the Android framework is changing this behavior and this is breaking DPAD keys. BUG=b/14438911 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Primiano Tucci (use gerrit)
Aurimas, how would you feel seeing a change like this? I have absolutely no idea ...
6 years, 7 months ago (2014-05-06 15:55:00 UTC) #1
Primiano Tucci (use gerrit)
I did a smoke test with https://thefiletree.com/primiano/form.html?plug=none and the JS key modifiers seem to work ...
6 years, 7 months ago (2014-05-08 11:08:32 UTC) #2
benm (inactive)
lgtm
6 years, 7 months ago (2014-05-08 11:09:17 UTC) #3
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 7 months ago (2014-05-08 11:18:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/267903005/1
6 years, 7 months ago (2014-05-08 11:21:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 18:17:41 UTC) #6
Primiano Tucci (use gerrit)
Adding NOTRY, win_rel flake as usual :/
6 years, 7 months ago (2014-05-08 18:20:49 UTC) #7
Primiano Tucci (use gerrit)
The CQ bit was unchecked by primiano@chromium.org
6 years, 7 months ago (2014-05-08 18:21:02 UTC) #8
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 7 months ago (2014-05-08 18:21:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/267903005/1
6 years, 7 months ago (2014-05-08 18:27:24 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 15:05:08 UTC) #11
Message was sent while issue was closed.
Change committed as 269302

Powered by Google App Engine
This is Rietveld 408576698