[DevTools] Show an empty Manifest view if no manifest

third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js

 /*
  * Copyright (C) 2007, 2008, 2010 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 96 matching lines @@
     this._domStorageTreeElements = new Map();
     /** @type {!Object.<string, !Resources.CookieItemsView>} */
     this._cookieViews = {};
     /** @type {!Object.<string, boolean>} */
     this._domains = {};
 
     this.panelSidebarElement().addEventListener('mousemove', this._onmousemove.bind(this), false);
     this.panelSidebarElement().addEventListener('mouseleave', this._onmouseleave.bind(this), false);
 
     SDK.targetManager.observeTargets(this);
+    SDK.targetManager.addEventListener(
+        SDK.TargetManager.Events.MainFrameNavigated,
+        event => this._manifestTreeElement.loadManifest(event.data.target()));

[pfeldman, 2017/02/07 02:11:44]

You only want to load manifest if the view is visible.

[eostroukhov, 2017/02/07 19:16:51]

Done.

+
+    var mainTarget = SDK.targetManager.mainTarget();

[pfeldman, 2017/02/07 02:11:44]

ditto

[eostroukhov, 2017/02/07 19:16:51]

Done.

+    if (mainTarget)
+      this._manifestTreeElement.loadManifest(mainTarget);
   }
 
   /**
    * @return {!Resources.ResourcesPanel}
    */
   static _instance() {
     return /** @type {!Resources.ResourcesPanel} */ (self.runtime.sharedInstance(Resources.ResourcesPanel));
   }
 
   /**
@@ skipping 506 matching lines @@
     this._innerShowView(view);
   }
 
   showCategoryView(categoryName) {
     if (!this._categoryView)
       this._categoryView = new Resources.StorageCategoryView();
     this._categoryView.setText(categoryName);
     this._innerShowView(this._categoryView);
   }
 
+  /**
+   * @param {!UI.Widget} view
+   */
   _innerShowView(view) {
     if (this.visibleView === view)
       return;
 
     if (this.visibleView)
       this.visibleView.detach();
 
     view.show(this.storageViews);
     this.visibleView = view;
 
@@ skipping 768 matching lines @@
    */
   onselect(selectedByUser) {
     super.onselect(selectedByUser);
     if (!this._view)
       this._view = new Resources.ServiceWorkersView();
     this._storagePanel._innerShowView(this._view);
     return false;
   }
 };
 
-/**
- * @unrestricted
- */
 Resources.AppManifestTreeElement = class extends Resources.BaseStorageTreeElement {
   /**
    * @param {!Resources.ResourcesPanel} storagePanel
    */
   constructor(storagePanel) {
     super(storagePanel, Common.UIString('Manifest'), false);
+    /** @type {?Resources.AppManifestView} */
+    this._view = null;
+    /** @type {string} */
+    this._manifestUrl = '';
+    /** @type {?string} */
+    this._manifestData = null;
+    /** @type {!Array<!Protocol.Page.AppManifestError>} */
+    this._manifestFetchErrors = [];
+    this.selectable = false;
+
     var icon = UI.Icon.create('mediumicon-manifest', 'resource-tree-item');
     this.setLeadingIcons([icon]);
   }
 
   /**
    * @return {string}
    */
   get itemURL() {
     return 'manifest://';
   }
 
   /**
    * @override
+   * @param {boolean=} selectedByUser
    * @return {boolean}
    */
   onselect(selectedByUser) {
+    if (!this.selectable)
+      return false;
     super.onselect(selectedByUser);
-    if (!this._view)
+    if (!this._view) {
       this._view = new Resources.AppManifestView();
+      this._view.renderManifest(this._manifestUrl, this._manifestData, this._manifestFetchErrors);
+    }
     this._storagePanel._innerShowView(this._view);
     return false;
   }
+
+  /**
+   * @param {!SDK.Target} target
+   */
+  loadManifest(target) {
+    SDK.ResourceTreeModel.fromTarget(target).fetchAppManifest(this._onManifestFetched.bind(this));
+  }
+
+  /**
+   * @param {string} url
+   * @param {?string} data
+   * @param {!Array<!Protocol.Page.AppManifestError>} errors
+   */
+  _onManifestFetched(url, data, errors) {
+    this._manifestUrl = url;
+    this._manifestData = data;
+    this._manifestFetchErrors = errors;
+
+    this._setEnabled(!!data || !!errors.length);
+
+    if (this._view)
+      this._view.renderManifest(url, data, errors);
+  }
+
+  /**
+   * @param {boolean} enabled
+   */
+  _setEnabled(enabled) {
+    this.selectable = enabled;
+    this.listItemElement.classList.toggle('resource-sidebar-item-disabled', !enabled);
+  }
 };
 
 /**
  * @unrestricted
  */
 Resources.ClearStorageTreeElement = class extends Resources.BaseStorageTreeElement {
   /**
    * @param {!Resources.ResourcesPanel} storagePanel
    */
   constructor(storagePanel) {
@@ skipping 620 matching lines @@
 
     this.element.classList.add('storage-view');
     this._emptyWidget = new UI.EmptyWidget('');
     this._emptyWidget.show(this.element);
   }
 
   setText(text) {
     this._emptyWidget.text = text;
   }
 };