ios/web_view/internal/criwv_web_main_parts.mm - Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/criwv_web_main_parts.mm

Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState. (Closed)

Patch Set: Rebase. Respond to comments. Fix duplicate unique_ptr. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/internal/criwv_web_main_parts.mm

diff --git a/ios/web_view/internal/criwv_web_main_parts.mm b/ios/web_view/internal/criwv_web_main_parts.mm

index b1ec766e8caa41b69710e637bbbc3f163234311a..dd491d1cce36dbc8c1c0be3e7f6ca2e859767e5c 100644

--- a/ios/web_view/internal/criwv_web_main_parts.mm

+++ b/ios/web_view/internal/criwv_web_main_parts.mm

@@ -32,7 +32,8 @@ void CRIWVWebMainParts::PreMainMessageLoopRun() {

ui::ResourceBundle::GetSharedInstance().AddDataPackFromPath(

pak_file, ui::SCALE_FACTOR_NONE);

- browser_state_ = base::MakeUnique<CRIWVBrowserState>();

+ browser_state_ = base::MakeUnique<CRIWVBrowserState>(false);

+ off_the_record_browser_state_ = base::MakeUnique<CRIWVBrowserState>(true);

// Initialize translate.

translate::TranslateDownloadManager* download_manager =