ios/web_view/internal/criwv_browser_state.mm - Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/criwv_browser_state.mm

Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState. (Closed)

Patch Set: Rebase. Respond to comments. Fix duplicate unique_ptr. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/internal/criwv_browser_state.mm

diff --git a/ios/web_view/internal/criwv_browser_state.mm b/ios/web_view/internal/criwv_browser_state.mm

index 5833f9965a453b24c4dbbfc1a49a53d85999215e..4c4f16ac6f025263d5ae787423d365dfb327ce6d 100644

--- a/ios/web_view/internal/criwv_browser_state.mm

+++ b/ios/web_view/internal/criwv_browser_state.mm

@@ -28,7 +28,8 @@ const char kPreferencesFilename[] = FILE_PATH_LITERAL("Preferences");

namespace ios_web_view {

-CRIWVBrowserState::CRIWVBrowserState() : web::BrowserState() {

+CRIWVBrowserState::CRIWVBrowserState(bool off_the_record)

+ : web::BrowserState(), off_the_record_(off_the_record) {

CHECK(PathService::Get(base::DIR_APP_DATA, &path_));

request_context_getter_ = new CRIWVURLRequestContextGetter(

@@ -67,7 +68,7 @@ CRIWVBrowserState* CRIWVBrowserState::FromBrowserState(

}

bool CRIWVBrowserState::IsOffTheRecord() const {

- return false;

+ return off_the_record_;

}

base::FilePath CRIWVBrowserState::GetStatePath() const {