ios/web_view/public/criwv_web_view_configuration.h - Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/public/criwv_web_view_configuration.h

Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState. (Closed)

Patch Set: Respond to comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_VIEW_PUBLIC_CRIWV_WEB_VIEW_CONFIGURATION_H_

	6 #define IOS_WEB_VIEW_PUBLIC_CRIWV_WEB_VIEW_CONFIGURATION_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @class CRIWVWebsiteDataStore;

	11

	12 // Configuration used for creation of a CRIWVWebView.

	13 @interface CRIWVWebViewConfiguration : NSObject
	Eugene But (OOO till 7-30) 2017/02/07 01:27:46 This should conform to NSCopying. Otherwise callin This should conform to NSCopying. Otherwise calling copy will crash the app michaeldo 2017/02/08 20:40:48 Done. Show quoted text On 2017/02/07 01:27:46, Eugene But wrote: > This should conform to NSCopying. Otherwise calling copy will crash the app Done.
	14

	15 // Data store defining persistance of website data. Default is

	16 // [CRIWVWebsiteDataStore defaultDataStore].

	17 @property(nonatomic, strong, nonnull) CRIWVWebsiteDataStore* websiteDataStore;

	18

	19 @end

	20

	21 #endif // IOS_WEB_VIEW_PUBLIC_CRIWV_WEB_VIEW_CONFIGURATION_H_

OLD	NEW