ios/web_view/internal/criwv_web_view_internal.h - Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/internal/criwv_web_view_internal.h

Issue 2679003002: Initialize CRIWVWebView with Configuration object instead of browserState. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/web_view/internal/criwv_web_view_configuration.mm ('K') | « ios/web_view/internal/criwv_web_view_configuration.mm ('k') | ios/web_view/internal/criwv_website_data_store.mm » ('j') | ios/web_view/public/criwv_web_view_configuration.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_VIEW_IMPL_H_	5 #ifndef IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_VIEW_IMPL_H_

6 #define IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_VIEW_IMPL_H_	6 #define IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_VIEW_IMPL_H_

7	7

8 #import "ios/web_view/public/criwv_web_view.h"	8 #import "ios/web_view/public/criwv_web_view.h"

9	9

10 namespace ios_web_view {	10 @class CRIWVWebViewConfiguration;

11 class CRIWVBrowserState;

12 }

13	11

14 @interface CRIWVWebView ()	12 @interface CRIWVWebView ()

15	13

16 // \|browserState\| cannot be nil.	14 // \|configuration\| cannot be nil.

17 - (instancetype)initWithFrame:(CGRect)frame	15 - (instancetype)initWithFrame:(CGRect)frame

18 browserState:(ios_web_view::CRIWVBrowserState*)browserState	16 configuration:(CRIWVWebViewConfiguration*)configuration
	Eugene But (OOO till 7-30) 2017/02/06 23:31:56 This should be a public WebView method now. This should be a public WebView method now. michaeldo 2017/02/06 23:53:50 That's right, thanks for the catch. Show quoted text On 2017/02/06 23:31:56, Eugene But wrote: > This should be a public WebView method now. That's right, thanks for the catch.
19 NS_DESIGNATED_INITIALIZER;	17 NS_DESIGNATED_INITIALIZER;

20	18

21 @end	19 @end

22	20

23 #endif // IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_VIEW_IMPL_H_	21 #endif // IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_VIEW_IMPL_H_

OLD	NEW