Battery Status API: add plumbing for multi-platform support.

Battery Status API: add plumbing for multi-platform support.

Make the battery_status_manager generic for all platforms.
Currently there is an implementation only for the android
platform.

BUG=122593, 360068
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270124

[timvolodine, 2014-05-02 15:57:25]

+bulach@ : content/browser/android/browser_jni_registrar.cc

[bulach, 2014-05-02 16:41:15]

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
File content/browser/battery_status/battery_status_manager.h (right):

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
content/browser/battery_status/battery_status_manager.h:22:
BatteryStatusManager(const BatteryStatusUpdateCallback& callback);
nit: explicit

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
File content/browser/battery_status/battery_status_manager_default.cc (right):

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
content/browser/battery_status/battery_status_manager_default.cc:5: #include
"content/browser/battery_status/battery_status_manager.h"
I suppose you'll need 
#include "base/logging/logging.h" to get the NOTIMPLEMENTED macro and make the
bots happy.

[timvolodine, 2014-05-06 12:12:18]

thanks for the comments Marcus.

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
File content/browser/battery_status/battery_status_manager.h (right):

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
content/browser/battery_status/battery_status_manager.h:22:
BatteryStatusManager(const BatteryStatusUpdateCallback& callback);
On 2014/05/02 16:41:15, bulach wrote:
> nit: explicit

Done.

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
File content/browser/battery_status/battery_status_manager_default.cc (right):

https://codereview.chromium.org/267893003/diff/1/content/browser/battery_stat...
content/browser/battery_status/battery_status_manager_default.cc:5: #include
"content/browser/battery_status/battery_status_manager.h"
On 2014/05/02 16:41:15, bulach wrote:
> I suppose you'll need 
> #include "base/logging/logging.h" to get the NOTIMPLEMENTED macro and make the
> bots happy.

yes indeed. Done.

[Michael van Ouwerkerk, 2014-05-06 12:23:56]

lgtm

https://codereview.chromium.org/267893003/diff/20001/content/browser/battery_...
File content/browser/battery_status/battery_status_manager.h (right):

https://codereview.chromium.org/267893003/diff/20001/content/browser/battery_...
content/browser/battery_status/battery_status_manager.h:29: // Stop listenting
for battery status changes
Nit: end with a period.

[timvolodine, 2014-05-06 12:31:48]

https://codereview.chromium.org/267893003/diff/20001/content/browser/battery_...
File content/browser/battery_status/battery_status_manager.h (right):

https://codereview.chromium.org/267893003/diff/20001/content/browser/battery_...
content/browser/battery_status/battery_status_manager.h:29: // Stop listenting
for battery status changes
On 2014/05/06 12:23:57, Michael van Ouwerkerk wrote:
> Nit: end with a period.

Done.

[timvolodine, 2014-05-07 15:56:56]

On 2014/05/06 12:31:48, timvolodine wrote:
>
https://codereview.chromium.org/267893003/diff/20001/content/browser/battery_...
> File content/browser/battery_status/battery_status_manager.h (right):
> 
>
https://codereview.chromium.org/267893003/diff/20001/content/browser/battery_...
> content/browser/battery_status/battery_status_manager.h:29: // Stop listenting
> for battery status changes
> On 2014/05/06 12:23:57, Michael van Ouwerkerk wrote:
> > Nit: end with a period.
> 
> Done.

Marcus, friendly ping.

[bulach, 2014-05-07 16:03:15]

lgtm, thanks! small nits and suggestions below.

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
File content/browser/battery_status/battery_status_manager.h (right):

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
content/browser/battery_status/battery_status_manager.h:38: jdouble
chargingTime, jdouble dischargingTime,
nit: sorry, while at it: s/gTime/g_time/

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
File content/browser/battery_status/battery_status_manager_android.cc (right):

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
content/browser/battery_status/battery_status_manager_android.cc:32:
NOTIMPLEMENTED();
nit: since it already have all the info it needs, perhaps build the
WebBatteryStatus and callback_.Run(status) ?

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
File content/browser/battery_status/battery_status_update_callback.h (right):

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
content/browser/battery_status/battery_status_update_callback.h:14:
BatteryStatusUpdateCallback;
nit: would it make sense to put this into the manager since it can only be used
there?

[timvolodine, 2014-05-09 15:23:49]

thanks for the reviews!

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
File content/browser/battery_status/battery_status_manager.h (right):

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
content/browser/battery_status/battery_status_manager.h:38: jdouble
chargingTime, jdouble dischargingTime,
On 2014/05/07 16:03:15, bulach wrote:
> nit: sorry, while at it: s/gTime/g_time/

Done.

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
File content/browser/battery_status/battery_status_manager_android.cc (right):

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
content/browser/battery_status/battery_status_manager_android.cc:32:
NOTIMPLEMENTED();
On 2014/05/07 16:03:15, bulach wrote:
> nit: since it already have all the info it needs, perhaps build the
> WebBatteryStatus and callback_.Run(status) ?

Done.

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
File content/browser/battery_status/battery_status_update_callback.h (right):

https://codereview.chromium.org/267893003/diff/60001/content/browser/battery_...
content/browser/battery_status/battery_status_update_callback.h:14:
BatteryStatusUpdateCallback;
On 2014/05/07 16:03:15, bulach wrote:
> nit: would it make sense to put this into the manager since it can only be
used
> there?

this will be used by other classes as well, that's why I put it separately.

[timvolodine, 2014-05-13 15:47:14]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2014-05-13 15:47:49]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/timvolodine@chromium.org/267893003/100001

[commit-bot: I haz the power, 2014-05-13 16:41:56]

Change committed as 270124