[Payments] Only record abort metrics if the Payment Request was shown.

chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
index 2cf087ed23fee3dc8b689108d6cf3402ba66031a..709855b12dbd76517f3fc3de7d7233d579c5e183 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
@@ -40,14 +40,22 @@ public final class PaymentRequestMetrics {
     @VisibleForTesting
     public static final int ABORT_REASON_INSTRUMENT_DETAILS_ERROR = 5;
     @VisibleForTesting
-    public static final int ABORT_REASON_NO_MATCHING_PAYMENT_METHOD = 6;
+    public static final int ABORT_REASON_NO_MATCHING_PAYMENT_METHOD = 6; // Deprecated.
     @VisibleForTesting
-    public static final int ABORT_REASON_NO_SUPPORTED_PAYMENT_METHOD = 7;
+    public static final int ABORT_REASON_NO_SUPPORTED_PAYMENT_METHOD = 7; // Deprecated.
     @VisibleForTesting
     public static final int ABORT_REASON_OTHER = 8;

[please use gerrit instead, 2017/02/06 22:42:14]

I have not seen this used anywhere. What is its purpose? I plan to use it soon
for inexplicable errors, if that's OK ;-) http://crrev.com/2666953005

[sebsg, 2017/02/06 22:48:03]

That's exactly why it's there :) To be used for errors that should never happen.
If at some point we see that this happens in the wild, we can spit it to be more
explicit of the error.

     @VisibleForTesting
     public static final int ABORT_REASON_MAX = 9;
 
+    // PaymentRequestNoShowReason defined in tools/metrics/histograms/histograms.xml
+    @VisibleForTesting
+    public static final int NO_SHOW_NO_MATCHING_PAYMENT_METHOD = 0;
+    @VisibleForTesting
+    public static final int NO_SHOW_NO_SUPPORTED_PAYMENT_METHOD = 1;
+    @VisibleForTesting
+    public static final int NO_SHOW_REASON_MAX = 2;
+
     // PaymentRequestPaymentMethods defined in tools/metrics/histograms/histograms.xml.
     @VisibleForTesting
     public static final int SELECTED_METHOD_CREDIT_CARD = 0;