sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart - Issue 26789008: Fixing double-completing indexed DB transactions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

Issue 26789008: Fixing double-completing indexed DB transactions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

diff --git a/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart b/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

index 5b2948dfec31367eac7ea807fb43b75fa684ea90..e5d187f873dcb5144e5c63e7e7fa6da81b8b370c 100644

--- a/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

+++ b/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

@@ -1261,7 +1261,10 @@ class Transaction extends EventTarget native "IDBTransaction" {

});

this.onAbort.first.then((e) {

- completer.completeError(e);

+ // Avoid completing twice if an error occurs.

+ if (!completer.isCompleted) {

+ completer.completeError(e);

+ }

});

return completer.future;