base/files/file_util.cc - Issue 2678813003: Disable fd/handle sharing in base::ReadFileToString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_util.cc

Issue 2678813003: Disable fd/handle sharing in base::ReadFileToString. (Closed)

Patch Set: comment tweaks Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_util.cc

diff --git a/base/files/file_util.cc b/base/files/file_util.cc

index 80fa44f9ea22648fb7b9e9a55e67a049abcb66c0..70ff83a6e1cfe52efb4733f8f9703d2ad3b767d6 100644

--- a/base/files/file_util.cc

+++ b/base/files/file_util.cc

@@ -131,7 +131,7 @@ bool ReadFileToStringWithMaxSize(const FilePath& path,

contents->clear();

if (path.ReferencesParent())

return false;

- FILE* file = OpenFile(path, "rb");

+ FILE* file = OpenFile(path, "rb" FONE);

if (!file) {

return false;

}

« no previous file with comments | « base/files/file_util.h ('k') | no next file » | no next file with comments »